Skip to content

fix: return project item id usable for updates#2169

Merged
SamMorrowDrums merged 2 commits into
github:mainfrom
njoppi2:fix/projects-write-item-id
May 31, 2026
Merged

fix: return project item id usable for updates#2169
SamMorrowDrums merged 2 commits into
github:mainfrom
njoppi2:fix/projects-write-item-id

Conversation

@njoppi2
Copy link
Copy Markdown
Contributor

@njoppi2 njoppi2 commented Mar 7, 2026

Summary

  • include fullDatabaseId in the GraphQL response for projects_write / add_project_item
  • return a numeric item_id that can be passed directly to update_project_item and delete_project_item
  • keep the existing node id in the response for backwards compatibility

Closes #2153.

Validation

  • ran go test ./pkg/github -run "Test_ProjectsWrite_AddProjectItem|Test_ProjectsWrite_UpdateProjectItem" in a Go 1.24 Docker container
  • formatted touched files with gofmt in the same container

@njoppi2 njoppi2 requested a review from a team as a code owner March 7, 2026 05:37
@SamMorrowDrums SamMorrowDrums force-pushed the fix/projects-write-item-id branch from af3968f to 5c0c341 Compare May 31, 2026 08:50
Copy link
Copy Markdown
Collaborator

@SamMorrowDrums SamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean fix for #2153 — adds fullDatabaseId to the mutation and returns both full_database_id (string) and item_id (int64) so the result can be passed straight into update_project_item / delete_project_item. Existing node id preserved for backwards compat. Rebased onto main, tests pass, lint clean. Thanks!

@SamMorrowDrums SamMorrowDrums merged commit 9266752 into github:main May 31, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

projects_write: item_id parameter typed as float64 instead of string

3 participants