Add unit tests for wolfSSHD_AuthReducePermissionsUser#994
Open
yosuke-wolfssl wants to merge 1 commit into
Open
Add unit tests for wolfSSHD_AuthReducePermissionsUser#994yosuke-wolfssl wants to merge 1 commit into
yosuke-wolfssl wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds unit tests around wolfSSHD_AuthReducePermissionsUser() to prevent regressions/mutations in the privilege-drop flow by validating the expected setregid()/setreuid() call behavior (success path and failure paths). To enable deterministic testing, the PR introduces unit-test-only indirection via function pointers so tests can stub the underlying syscalls.
Changes:
- Added unit tests for
wolfSSHD_AuthReducePermissionsUser()covering success, GID failure, and UID failure paths (non-Windows only). - Added unit-test-only callback hooks (
wsshd_setregid_cb,wsshd_setreuid_cb) and used them insidewolfSSHD_AuthReducePermissionsUser()whenWOLFSSHD_UNIT_TESTis enabled. - Exposed the callback hooks via
auth.hfor the test binary to install/restore stubs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
| apps/wolfsshd/test/test_configuration.c | Adds POSIX-only unit tests that stub privilege-drop syscalls and assert expected call behavior. |
| apps/wolfsshd/auth.h | Exposes unit-test-only extern hooks for syscall indirection used by the new tests. |
| apps/wolfsshd/auth.c | Adds unit-test-only syscall indirection and switches wolfSSHD_AuthReducePermissionsUser() to use it under test builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yosuke-wolfssl
force-pushed
the
fix/f_5578
branch
from
a38f33e to
73d67f6
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #994
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for wolfSSHD_AuthReducePermissionsUser so that this can prevent any mutations against user privilege drop calls on that.