Pr 3310 fix#3323
Conversation
deepshekhardas
force-pushed
the
pr-3310-fix
branch
from
94d7199 to
78364c6
Compare
🦋 Changeset detectedLatest commit: 78364c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This PR has been rebased onto latest main. Could you please review? 🙏 |
WalkthroughThis PR removes the Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚩 V1 engine WAITING_FOR_DEPLOY runs will no longer be drained on deployment
The removed code in changeCurrentDeployment.server.ts specifically guarded the ExecuteTasksWaitingForDeployService.enqueue call behind a worker?.engine === 'V1' check. This means V1 engine workers that have runs stuck in WAITING_FOR_DEPLOY status will no longer have those runs transitioned to PENDING and enqueued into marqs when a new deployment is promoted. The WAITING_FOR_DEPLOY status still exists in the database schema (internal-packages/database/prisma/schema.prisma:1137) and is referenced throughout the UI code. If there are still active V1 engine environments, this could leave runs permanently stuck. However, per the CLAUDE.md architecture notes, V1 is in deprecation mode and all new work targets V2/Run Engine 2.0, which uses PENDING_VERSION instead. The deleted service also had a kill-switch env var (LEGACY_RUN_ENGINE_WAITING_FOR_DEPLOY_DISABLED), suggesting this was already being phased out.
Was this helpful? React with 👍 or 👎 to provide feedback.
| @@ -0,0 +1,7 @@ | |||
| --- | |||
| "@trigger.dev/core": patch | |||
There was a problem hiding this comment.
🟡 Changeset targets @trigger.dev/core but no package code was changed — should be a .server-changes/ file
The changeset declares "@trigger.dev/core": patch but this PR only changes files in apps/webapp/. No files under packages/core/ (or any other packages/ directory) were modified. Per the CONTRIBUTING.md rules table, server-only PRs should add a .server-changes/ file instead of a changeset. This changeset would cause a spurious patch release of @trigger.dev/core with no actual code changes, creating noise for downstream consumers.
Prompt for agents
The changeset file .changeset/fix-v3-executing-tasks.md references @trigger.dev/core: patch, but this PR only modifies files in apps/webapp/ (server-only changes). Per CONTRIBUTING.md, server-only changes should not use a changeset. Instead:
1. Delete .changeset/fix-v3-executing-tasks.md
2. Create a new file .server-changes/fix-v3-executing-tasks.md with the content:
---
area: webapp
type: fix
---
Remove ExecuteTasksWaitingForDeployService and its no-op handlers for the legacy V1 WAITING_FOR_DEPLOY drain
Was this helpful? React with 👍 or 👎 to provide feedback.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/webapp/app/services/worker.server.ts (1)
218-223: ⚡ Quick winv3.executeTasksWaitingForDeploy: enqueue calls appear removed; add a deprecation/no-op comment
Search results show
executeTasksWaitingForDeploy/v3.executeTasksWaitingForDeployare referenced only in the job registration/schema and the empty handler bodies; there are no remainingExecuteTasksWaitingForDeployServicereferences or internalenqueue/triggerusages.Add an explanatory comment to the empty handler (it’s currently a silent no-op) in
apps/webapp/app/services/worker.server.ts(and similarly inapps/webapp/app/v3/commonWorker.server.ts).📝 Suggested comment for clarity
"v3.executeTasksWaitingForDeploy": { priority: 0, maxAttempts: 5, handler: async (payload, job) => { + // No-op: ExecuteTasksWaitingForDeployService removed; enqueue calls eliminated }, },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/webapp/app/services/worker.server.ts` around lines 218 - 223, Add an explicit deprecation/no-op comment inside the empty handler for v3.executeTasksWaitingForDeploy to make the silent no-op intentional and explain why (e.g., ExecuteTasksWaitingForDeployService/enqueue was removed and this job kept for schema/compatibility); update the same explanatory comment in the corresponding empty handler in v3/commonWorker.server.ts; reference v3.executeTasksWaitingForDeploy and ExecuteTasksWaitingForDeployService in the comment so future readers know it was retired rather than accidentally deleted.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@apps/webapp/app/services/worker.server.ts`:
- Around line 218-223: Add an explicit deprecation/no-op comment inside the
empty handler for v3.executeTasksWaitingForDeploy to make the silent no-op
intentional and explain why (e.g., ExecuteTasksWaitingForDeployService/enqueue
was removed and this job kept for schema/compatibility); update the same
explanatory comment in the corresponding empty handler in
v3/commonWorker.server.ts; reference v3.executeTasksWaitingForDeploy and
ExecuteTasksWaitingForDeployService in the comment so future readers know it was
retired rather than accidentally deleted.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 122dc075-b713-4e7c-9996-c0102a620b09
📒 Files selected for processing (6)
.changeset/fix-v3-executing-tasks.mdapps/webapp/app/services/worker.server.tsapps/webapp/app/v3/commonWorker.server.tsapps/webapp/app/v3/services/changeCurrentDeployment.server.tsapps/webapp/app/v3/services/createDeploymentBackgroundWorkerV3.server.tsapps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts
💤 Files with no reviewable changes (4)
- apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts
- apps/webapp/app/v3/commonWorker.server.ts
- apps/webapp/app/v3/services/createDeploymentBackgroundWorkerV3.server.ts
- apps/webapp/app/v3/services/changeCurrentDeployment.server.ts
📜 Review details
🧰 Additional context used
📓 Path-based instructions (7)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead
Files:
apps/webapp/app/services/worker.server.ts
{packages/core,apps/webapp}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use zod for validation in packages/core and apps/webapp
Files:
apps/webapp/app/services/worker.server.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Use function declarations instead of default exports
**/*.{ts,tsx,js,jsx}: Prefer static imports over dynamic imports. Only use dynamicimport()when circular dependencies cannot be resolved otherwise, code splitting is needed for performance, or the module must be loaded conditionally at runtime.
Import from@trigger.dev/coreusing subpaths only - never import from the root.
When writing Trigger.dev tasks, always import from@trigger.dev/sdk. Never use@trigger.dev/sdk/v3or deprecatedclient.defineJob.
Add agentcrumbs markers (//@Crumbsor `#region `@crumbs) as you write code, not just when debugging. They stay on the branch throughout development and are stripped byagentcrumbs stripbefore merge.
Files:
apps/webapp/app/services/worker.server.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/otel-metrics.mdc)
**/*.ts: When creating or editing OTEL metrics (counters, histograms, gauges), ensure metric attributes have low cardinality by using only enums, booleans, bounded error codes, or bounded shard IDs
Do not use high-cardinality attributes in OTEL metrics such as UUIDs/IDs (envId, userId, runId, projectId, organizationId), unbounded integers (itemCount, batchSize, retryCount), timestamps (createdAt, startTime), or free-form strings (errorMessage, taskName, queueName)
When exporting OTEL metrics via OTLP to Prometheus, be aware that the exporter automatically adds unit suffixes to metric names (e.g., 'my_duration_ms' becomes 'my_duration_ms_milliseconds', 'my_counter' becomes 'my_counter_total'). Account for these transformations when writing Grafana dashboards or Prometheus queries
Files:
apps/webapp/app/services/worker.server.ts
apps/webapp/**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/webapp.mdc)
apps/webapp/**/*.{ts,tsx}: Access environment variables through theenvexport ofenv.server.tsinstead of directly accessingprocess.env
Use subpath exports from@trigger.dev/corepackage instead of importing from the root@trigger.dev/corepathUse named constants for sentinel/placeholder values (e.g.
const UNSET_VALUE = '__unset__') instead of raw string literals scattered across comparisons
Files:
apps/webapp/app/services/worker.server.ts
apps/webapp/**/*.server.ts
📄 CodeRabbit inference engine (apps/webapp/CLAUDE.md)
apps/webapp/**/*.server.ts: Never userequest.signalfor detecting client disconnects. UsegetRequestAbortSignal()fromapp/services/httpAsyncStorage.server.tsinstead, which is wired directly to Expressres.on('close')and fires reliably
Access environment variables viaenvexport fromapp/env.server.ts. Never useprocess.envdirectly
Always usefindFirstinstead offindUniquein Prisma queries.findUniquehas an implicit DataLoader that batches concurrent calls and has active bugs even in Prisma 6.x (uppercase UUIDs returning null, composite key SQL correctness issues, 5-10x worse performance).findFirstis never batched and avoids this entire class of issues
Files:
apps/webapp/app/services/worker.server.ts
**/*.{js,jsx,ts,tsx,json,md,yml,yaml}
📄 CodeRabbit inference engine (AGENTS.md)
Code formatting must be enforced using Prettier before committing
Files:
apps/webapp/app/services/worker.server.ts
🧠 Learnings (7)
📚 Learning: 2026-03-22T13:26:12.060Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3244
File: apps/webapp/app/components/code/TextEditor.tsx:81-86
Timestamp: 2026-03-22T13:26:12.060Z
Learning: In the triggerdotdev/trigger.dev codebase, do not flag `navigator.clipboard.writeText(...)` calls for `missing-await`/`unhandled-promise` issues. These clipboard writes are intentionally invoked without `await` and without `catch` handlers across the project; keep that behavior consistent when reviewing TypeScript/TSX files (e.g., usages like in `apps/webapp/app/components/code/TextEditor.tsx`).
Applied to files:
apps/webapp/app/services/worker.server.ts
📚 Learning: 2026-03-22T19:24:14.403Z
Learnt from: matt-aitken
Repo: triggerdotdev/trigger.dev PR: 3187
File: apps/webapp/app/v3/services/alerts/deliverErrorGroupAlert.server.ts:200-204
Timestamp: 2026-03-22T19:24:14.403Z
Learning: In the triggerdotdev/trigger.dev codebase, webhook URLs are not expected to contain embedded credentials/secrets (e.g., fields like `ProjectAlertWebhookProperties` should only hold credential-free webhook endpoints). During code review, if you see logging or inclusion of raw webhook URLs in error messages, do not automatically treat it as a credential-leak/secrets-in-logs issue by default—first verify the URL does not contain embedded credentials (for example, no username/password in the URL, no obvious secret/token query params or fragments). If the URL is credential-free per this project’s conventions, allow the logging.
Applied to files:
apps/webapp/app/services/worker.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma error P1001 ("Can't reach database server") in TypeScript, don’t assume a single error shape. Prisma can surface P1001 via two different error classes/fields: `PrismaClientKnownRequestError` exposes it as `err.code === "P1001"` (common during mid-query connection drops), while `PrismaClientInitializationError` exposes it as `err.errorCode === "P1001"` (common on client startup failure). Therefore, predicates should use `err.code === "P1001" || err.errorCode === "P1001"`. Do not flag `err.code === "P1001"` as “unreachable/never matches,” as it is expected in production.
Applied to files:
apps/webapp/app/services/worker.server.ts
📚 Learning: 2026-05-18T08:21:27.694Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3632
File: apps/webapp/sentry.server.ts:4-21
Timestamp: 2026-05-18T08:21:27.694Z
Learning: When handling Prisma errors for P1001 ("Can't reach database server"), do not assume it only appears under a single property name. Prisma may surface P1001 via either `PrismaClientKnownRequestError` (`err.code === "P1001"`, e.g., mid-query connection drops) or `PrismaClientInitializationError` (`err.errorCode === "P1001"`, e.g., client startup connection failure). To reliably detect the condition, check `err.code === "P1001" || err.errorCode === "P1001"`, and avoid review rules that would incorrectly flag `err.code === "P1001"` as unreachable/never-matching.
Applied to files:
apps/webapp/app/services/worker.server.ts
📚 Learning: 2026-03-26T09:02:07.973Z
Learnt from: myftija
Repo: triggerdotdev/trigger.dev PR: 3274
File: apps/webapp/app/services/runsReplicationService.server.ts:922-924
Timestamp: 2026-03-26T09:02:07.973Z
Learning: When parsing Trigger.dev task run annotations in server-side services, keep `TaskRun.annotations` strictly conforming to the `RunAnnotations` schema from `trigger.dev/core/v3`. If the code already uses `RunAnnotations.safeParse` (e.g., in a `#parseAnnotations` helper), treat that as intentional/necessary for atomic, schema-accurate annotation handling. Do not recommend relaxing the annotation payload schema or using a permissive “passthrough” parse path, since the annotations are expected to be written atomically in one operation and should not contain partial/legacy payloads that would require a looser parser.
Applied to files:
apps/webapp/app/services/worker.server.ts
📚 Learning: 2026-05-05T09:38:02.512Z
Learnt from: d-cs
Repo: triggerdotdev/trigger.dev PR: 3523
File: apps/webapp/app/routes/api.v3.batches.ts:178-181
Timestamp: 2026-05-05T09:38:02.512Z
Learning: When reviewing code that catches `ServiceValidationError` in `*.server.ts` files, do not blindly forward `error.status` to HTTP responses, because SVEs may be thrown with non-default statuses (e.g., 400/500) and forwarding them can cause client-visible behavioral regressions (e.g., surfacing 500s to clients). Prefer a safe default response status of `error.status ?? 422`, but only after confirming via the reachable call graph that the caught `ServiceValidationError` instances are expected to carry those non-default statuses; otherwise, normalize to `422` to avoid unexpected client-visible 5xx behavior.
Applied to files:
apps/webapp/app/services/worker.server.ts
📚 Learning: 2026-05-12T21:04:05.815Z
Learnt from: ericallam
Repo: triggerdotdev/trigger.dev PR: 3542
File: apps/webapp/app/components/sessions/v1/SessionStatus.tsx:1-3
Timestamp: 2026-05-12T21:04:05.815Z
Learning: In this Remix + TypeScript codebase, do not flag a server/client boundary violation when a file imports only types from a module matching `*.server`.
Specifically, it’s safe to import types using `import type { Foo } from "*.server"` or `import { type Foo } from "*.server"` because TypeScript erases type-only imports at compile time and they emit no JavaScript, so they won’t cross the Remix server/client bundle boundary.
Only raise the boundary concern for value imports (e.g., `import { Foo }` without `type`, or `import Foo`), since those produce JavaScript output.
Applied to files:
apps/webapp/app/services/worker.server.ts
🪛 LanguageTool
.changeset/fix-v3-executing-tasks.md
[style] ~7-~7: Consider using a different verb for a more formal wording.
Context: ...ting to deploy from the task list. This fixes an issue where tasks in EXECUTING state...
(FIX_RESOLVE)
🔇 Additional comments (2)
apps/webapp/app/services/worker.server.ts (1)
287-287: LGTM!.changeset/fix-v3-executing-tasks.md (1)
1-3: ⚡ Quick winRe-target (or justify) the changeset package bump
The changeset bumps
@trigger.dev/core, butExecuteTasksWaitingForDeployServiceis not present anywhere inpackages/core(while the change description indicates it’s removing that service fromapps/webapp/). Reconfirm which workspace/package is actually affected (and whether the fix changes@trigger.dev/core’s public behavior/API); otherwise the bump target is likely incorrect.
2 participants
Removes the deprecated \ExecuteTasksWaitingForDeployService\ and its job handler.
Changes
Testing
Closes #3310