fix(docs): add missing createEffect and createSignal imports in lifecycle examples#1532
Open
xcfio wants to merge 1 commit into
Open
fix(docs): add missing createEffect and createSignal imports in lifecycle examples#1532xcfio wants to merge 1 commit into
xcfio wants to merge 1 commit into
Conversation
Added createEffect and createSignal imports to enhance component functionality.
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The lifecycle documentation examples for
onMountandonCleanupwere missing necessary imports from"solid-js", causing code snippets to be non-functional if copied directly by readers.Changes made:
onMountexample: addedcreateEffectandcreateSignalto the import statementonCleanupexample: addedcreateSignalto the import statementThis ensures documentation snippets are self-contained and copy-paste ready for developers learning SolidJS lifecycle primitives.
Related issues & labels
documentation,bug,fix