fix(signature): validate signing_secret is a non-empty string#1884
Open
WilliamBergamin wants to merge 1 commit into
Open
fix(signature): validate signing_secret is a non-empty string#1884WilliamBergamin wants to merge 1 commit into
WilliamBergamin wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1884 +/- ##
==========================================
+ Coverage 84.09% 84.14% +0.04%
==========================================
Files 117 117
Lines 13346 13356 +10
==========================================
+ Hits 11223 11238 +15
+ Misses 2123 2118 -5 ☔ View full report in Codecov by Sentry. |
zimeg
approved these changes
Jun 2, 2026
Member
zimeg
left a comment
There was a problem hiding this comment.
@WilliamBergamin LGTM! Tested with a bolt app to find a new error 👾 ✨
ValueError: signing_secret must not be empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds input validation to
SignatureVerifier.signing_secretto fail fast with a clear error when an empty or non-string value is provided. Previously, passing"",None, or a non-string type would silently produce incorrect HMAC signatures, making debugging difficult for users who misconfigured their app.signing_secretthat raisesValueErrorfor non-string or blank valuesNote: this is a similar fix as slackapi/bolt-js#2946
Testing
CI tests should be sufficient
Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.