fix: Render ColGroup even if table has no data to maintain layout consistency by wanpan11 · Pull Request #1490 · react-component/table

wanpan11 · 2026-05-28T18:18:47Z

Ensures FixedHolder renders the colgroup as long as column widths are available, fixing layout issues when the table is empty but has fixed columns. Fixes ant-design/ant-design/issues/57916

Summary by CodeRabbit

改进

Bug Fixes
- 优化表格在无数据或部分列宽可用时的渲染判断：只要列宽信息存在，仍保持表头、数据行与汇总行的列布局一致，避免布局错位。

…sistency Ensures FixedHolder renders the colgroup as long as column widths are available, fixing layout issues when the table is empty but has fixed columns. Fixes #57916.

coderabbitai · 2026-05-28T18:19:01Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c83cac73-62d8-494f-bc16-bd439724add1

📥 Commits

Reviewing files that changed from the base of the PR and between 2f44600 and d56e0c5.

📒 Files selected for processing (1)

src/FixedHolder/index.tsx

💤 Files with no reviewable changes (1)

src/FixedHolder/index.tsx

Walkthrough

将 FixedHolder 中用于决定是否渲染 ColGroup 的 isColGroupEmpty 条件从同时检查 noData 与列宽，改为仅基于列宽（mergedColumnWidth），并在 props 解构中移除 noData。

变更内容

列组渲染逻辑优化

Layer / File(s)	Summary
isColGroupEmpty 条件判断调整 `src/FixedHolder/index.tsx`	从 props 解构中移除 `noData`；`isColGroupEmpty` 的 useMemo 返回条件由原先的 `noData

🎯 3 (Moderate) | ⏱️ ~20 minutes

建议审阅者

afc163

总体说明（更新）

本 PR 对 FixedHolder 组件中 isColGroupEmpty 的渲染判断逻辑进行了调整，使其不再在无数据时立即跳过 ColGroup 的渲染，而是始终根据列宽信息来决定，以确保表头、表体、表尾在布局上保持一致。

🐰 诗歌

我是小兔来报到，列宽真时别跑，
即便数据尚未到，ColGroup 也别少；
表头表体同队形，布局一致最美好，
祝这次改动顺利，渲染稳定不飘摇～ 🐇✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	PR标题清晰准确地概括了主要变更：在表格无数据时仍渲染ColGroup以保持布局一致性，与文件变更内容完全相符。
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Removes the noData condition from the isColGroupEmpty check in FixedHolder so that the calculated ColGroup widths are used even when the table has no data, keeping Header/Body/Summary layouts aligned.

Changes:

Drop noData from the isColGroupEmpty memo and its dependency array.
Update the inline comment to describe the new behavior and reference ant-design issue #57916.
Update the FixedColumn snapshot to reflect the new colgroup widths emitted for the scrollXY-without-data case.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/FixedHolder/index.tsx	Removes `noData` from the ColGroup-empty check so calculated widths apply even with no data.
tests/snapshots/FixedColumn.spec.tsx.snap	Updates the no-data snapshot to match the new col widths produced by the change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vercel · 2026-05-28T18:19:36Z

@wanpan11 is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

gemini-code-assist

Code Review

This pull request updates FixedHolder to render the ColGroup as long as column widths are available, even when there is no data, ensuring layout consistency. A review comment correctly points out that noData is now an unused variable in FixedHolder and suggests resolving this to prevent potential ESLint warnings.

coderabbitai · 2026-05-28T18:21:39Z

Actionable comments posted: 0

wanpan11 · 2026-05-28T18:28:40Z

@gemini-code-assist review

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

gemini-code-assist

Code Review

This pull request updates the FixedHolder component to render the ColGroup as long as column widths are available, even when there is no data, which maintains layout consistency. A review comment notes that removing noData from the destructuring assignment could cause it to leak into restProps and be forwarded to DOM elements, potentially triggering React console warnings. It is recommended to keep noData in the destructuring to prevent this issue.

gemini-code-assist · 2026-05-28T18:29:22Z

  const {
    className,
    style,
-    noData,
    columns,


By removing noData from the destructuring assignment, it now implicitly falls into restProps. Since restProps is passed down to the children render prop (which eventually renders the header elements), noData will be forwarded down and may end up being spread onto DOM elements, triggering React console warnings (e.g., React does not recognize the noData prop on a DOM element).

To prevent this prop leakage, keep noData in the destructuring assignment so it is excluded from restProps, even if it is not directly used within FixedHolder.

Suggested change

const {

className,

style,

noData,

columns,

const {

className,

style,

noData,

columns,

coderabbitai · 2026-05-28T18:29:45Z

Actionable comments posted: 0

fix: Render ColGroup even if table has no data to maintain layout con…

2f44600

…sistency Ensures FixedHolder renders the colgroup as long as column widths are available, fixing layout issues when the table is empty but has fixed columns. Fixes #57916.

Copilot AI review requested due to automatic review settings May 28, 2026 18:18

Copilot AI reviewed May 28, 2026

View reviewed changes

gemini-code-assist Bot reviewed May 28, 2026

View reviewed changes

Comment thread src/FixedHolder/index.tsx

refactor: Remove unused noData variable in FixedHolder

d56e0c5

wanpan11 requested a review from Copilot May 28, 2026 18:28

Copilot AI reviewed May 28, 2026

View reviewed changes

gemini-code-assist Bot reviewed May 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Render ColGroup even if table has no data to maintain layout consistency#1490

fix: Render ColGroup even if table has no data to maintain layout consistency#1490
wanpan11 wants to merge 2 commits into
react-component:masterfrom
wanpan11:fix/issue-57916

wanpan11 commented May 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 28, 2026 •

edited

Loading

Review ran into problems

Uh oh!

Copilot AI left a comment

Uh oh!

vercel Bot commented May 28, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot commented May 28, 2026

Uh oh!

wanpan11 commented May 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot May 28, 2026

Uh oh!

coderabbitai Bot commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

wanpan11 commented May 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

改进

Uh oh!

coderabbitai Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

变更内容

相关 PR

建议审阅者

总体说明（更新）

🐰 诗歌

Review ran into problems

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

vercel Bot commented May 28, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

coderabbitai Bot commented May 28, 2026

Uh oh!

wanpan11 commented May 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot May 28, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wanpan11 commented May 28, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 28, 2026 •

edited

Loading