chore: manage Node via mise#7513
Open
olerass wants to merge 1 commit into
Open
Conversation
olerass
added
the
e2e
i1skn
approved these changes
May 26, 2026
DanielSinclair
approved these changes
May 28, 2026
| @@ -0,0 +1,5 @@ | |||
| [tools] | |||
| maestro = "cli-2.0.10" | |||
Contributor
There was a problem hiding this comment.
It looks like the Node version is missing here?
Contributor
There was a problem hiding this comment.
I think this is still useful signaling the nvm CLI and npm/bun/yarn and local dev workflows even when using mise; is this something we could keep or have auto-maintained by mise?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently pin the same Node version in two files (
.nvmrcand.node-version) that can drift, while Maestro sits separately in.tool-versions. Following on from #7511, the natural cleanup is to give mise full responsibility for tool versions without forcing a CI installer swap.This change moves Maestro into
mise.tomland configures mise to read.node-versionas the canonical Node source. For local dev we runmise installand get both. CI's Node install stays onactions/setup-nodepointed at.node-version, preserving the inlinetsc/eslintproblem matchers we'd lose by switching tomise-actionfor Node. Themise-actioncalls for Maestro now scope their install viainstall_argsso they don't pick up Node alongside.Bitrise's
nvm@1step reads.nvmrc, which this PR deletes, so a follow-up Bitrise migration to mise should land shortly after. Once that lands and actions/setup-node#1421 merges upstream, we can pointsetup-nodeatmise.tomldirectly and drop.node-versionfor a single canonical pin file.