gh-148508: Add another common pattern for iOS SSL failures#150442
Conversation
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 5e9b009 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F150442%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
| re.search( | ||
| r'wrong.version.number|record.layer.failure|http.request', | ||
| str(getattr(err, "reason", "")), | ||
| re.I |
There was a problem hiding this comment.
Nitpick:
| re.I | |
| re.IGNORECASE |
|
Thanks @freakboy3742 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-150697 is a backport of this pull request to the 3.15 branch. |
|
GH-150698 is a backport of this pull request to the 3.14 branch. |
|
GH-150699 is a backport of this pull request to the 3.13 branch. |
|
Merged, thanks for the fix @freakboy3742. |
|
The
test_ssl.TestPreHandshakeClose.test_preauth_data_to_tls_servertest fails intermittently on the iOS buildbot because an SSL error doesn't raise the expected TLS handshake error.This test already has an escape clause that allows a skip under certain error conditions (raising a ConnectionError, an OSError, or an SSL error with "wrong version number"). #148536 added a pattern for one type of iOS failure; this PR adds a second failure mode that is observed (simplifying the test into a single regex).
It also tweaks the iOS logging regex to strip an additional space; this should aid Bevedere in reporting stack traces when failures occur.