Skip to content

gh-149187: Document frozendict() under 'Built-in Functions'#149185

Merged
StanFromIreland merged 1 commit into
python:mainfrom
oyvindronningstad:doc-frozendict-functions
Jun 2, 2026
Merged

gh-149187: Document frozendict() under 'Built-in Functions'#149185
StanFromIreland merged 1 commit into
python:mainfrom
oyvindronningstad:doc-frozendict-functions

Conversation

@oyvindronningstad
Copy link
Copy Markdown
Contributor

@oyvindronningstad oyvindronningstad commented Apr 30, 2026 •
edited by bedevere-app Bot
Loading

Add frozendict to the Built-in Functions table, and add a short entry on the page, derived from the dict and frozenset entries.

Also, mention frozendict in the dict entry.

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented Apr 30, 2026 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Apr 30, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Apr 30, 2026
@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community Bot commented Apr 30, 2026 •
edited
Loading

Documentation build overview

📚 cpython-previews | 🛠️ Build #32953197 | 📁 Comparing 97e286d against main (7686abe)

  🔍 Preview build  

136 files changed · + 3 added · ± 133 modified

+ Added

± Modified

@oyvindronningstad oyvindronningstad changed the title Doc: Add frozendict to functions.rst gh-149187: Doc: Add frozendict to functions.rst Apr 30, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Apr 30, 2026
Open
sobolevn
sobolevn reviewed May 1, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread Doc/library/functions.rst
Comment thread Doc/library/functions.rst Outdated
Comment thread Doc/library/functions.rst
@oyvindronningstad oyvindronningstad force-pushed the doc-frozendict-functions branch from f0b8048 to 2bbe0c7 Compare May 2, 2026 15:58
@oyvindronningstad oyvindronningstad requested a review from sobolevn May 2, 2026 16:02
@oyvindronningstad
Copy link
Copy Markdown
Contributor Author

oyvindronningstad commented May 5, 2026

@sobolevn Thanks for the review! Are there other reviewers I should add?

@StanFromIreland
Copy link
Copy Markdown
Member

StanFromIreland commented May 5, 2026

Are there other reviewers I should add?

Please don't ping people at random. CODEOWNERS/experts are generally requested automatically.

StanFromIreland
StanFromIreland reviewed May 5, 2026
View reviewed changes
Comment thread Doc/library/functions.rst Outdated
@oyvindronningstad oyvindronningstad force-pushed the doc-frozendict-functions branch from 2bbe0c7 to c50a587 Compare May 7, 2026 08:16
@oyvindronningstad
Copy link
Copy Markdown
Contributor Author

oyvindronningstad commented May 7, 2026 •
edited
Loading

CODEOWNERS/experts are generally requested automatically.

I'm new here, but it might seem like that automation for this doesn't work for functions.rst. No reviewers were added for a number of days. Just FYI

StanFromIreland
StanFromIreland reviewed May 7, 2026
View reviewed changes
Comment thread Doc/library/functions.rst Outdated
@StanFromIreland
Copy link
Copy Markdown
Member

StanFromIreland commented May 7, 2026

No reviewers were added for a number of days.

That's because all reviewers have already been added.

@oyvindronningstad
Copy link
Copy Markdown
Contributor Author

oyvindronningstad commented May 7, 2026 •
edited
Loading

That's because all reviewers have already been added.

I meant before that. The PR had been open for 5 days when you were added. But again, I don't know anything about your codeowners system.

@oyvindronningstad oyvindronningstad force-pushed the doc-frozendict-functions branch from c50a587 to 786e218 Compare May 7, 2026 09:52
@oyvindronningstad oyvindronningstad force-pushed the doc-frozendict-functions branch from 786e218 to ad19967 Compare May 27, 2026 15:43
@oyvindronningstad
Copy link
Copy Markdown
Contributor Author

oyvindronningstad commented May 29, 2026

Is anything missing from my part for this to proceed?

StanFromIreland
StanFromIreland reviewed May 29, 2026
View reviewed changes
Comment thread Doc/library/functions.rst Outdated
@oyvindronningstad oyvindronningstad force-pushed the doc-frozendict-functions branch from ad19967 to 7f5dfe3 Compare June 1, 2026 08:00
@StanFromIreland StanFromIreland requested a review from vstinner June 1, 2026 08:39
StanFromIreland
StanFromIreland reviewed Jun 1, 2026
View reviewed changes
Comment thread Doc/library/functions.rst Outdated
@oyvindronningstad oyvindronningstad force-pushed the doc-frozendict-functions branch from 7f5dfe3 to 6d5dd40 Compare June 1, 2026 08:57
vstinner
vstinner reviewed Jun 1, 2026
View reviewed changes
Comment thread Doc/library/functions.rst
Comment thread Doc/library/functions.rst
@oyvindronningstad oyvindronningstad force-pushed the doc-frozendict-functions branch from 6d5dd40 to 3f5f622 Compare June 2, 2026 11:31
@oyvindronningstad
pythongh-149187: Doc: Add frozendict to functions.rst
97e286d 
Add frozendict to the Built-in Functions table, and add a short entry
on the page, derived from the dict and frozenset entries.

Also, mention frozendict in the dict entry.

Signed-off-by: Øyvind Rønningstad <oyvind.ronningstad@nordicsemi.no>
@oyvindronningstad oyvindronningstad force-pushed the doc-frozendict-functions branch from 3f5f622 to 97e286d Compare June 2, 2026 11:39
vstinner
vstinner approved these changes Jun 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The doc is rendered properly, and I can click on frozendict() in the table (the link works). I also checked that no function was removed by mistake in the table.

@vstinner vstinner added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 2, 2026
StanFromIreland
StanFromIreland approved these changes Jun 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanFromIreland StanFromIreland changed the title gh-149187: Doc: Add frozendict to functions.rst gh-149187: Document frozendict() under 'Built-in Functions' Jun 2, 2026
@StanFromIreland StanFromIreland merged commit 86867ed into python:main Jun 2, 2026
36 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 2, 2026
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Jun 2, 2026

Thanks @oyvindronningstad for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 2, 2026

GH-150789 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 2, 2026
StanFromIreland pushed a commit that referenced this pull request Jun 2, 2026
@miss-islington @oyvindronningstad
[3.15] gh-149187: Document frozendict() under 'Built-in Functions' (G…
33b2879 
…H-149185)

(cherry picked from commit 86867ed)

Co-authored-by: Øyvind Rønningstad <oyvind.ronningstad@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nedbat nedbat nedbat left review comments

@hugovk hugovk hugovk left review comments

@vstinner vstinner vstinner approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@sobolevn sobolevn Awaiting requested review from sobolevn

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@oyvindronningstad @StanFromIreland @nedbat @vstinner @hugovk @sobolevn