Skip to content

gh-141444:fix broken URLs and examples in urllib.request.rst#144863

Merged
orsenthil merged 3 commits into
python:mainfrom
tangyuan0821:141444
May 31, 2026
Merged

gh-141444:fix broken URLs and examples in urllib.request.rst#144863
orsenthil merged 3 commits into
python:mainfrom
tangyuan0821:141444

Conversation

@tangyuan0821
Copy link
Copy Markdown
Contributor

@tangyuan0821 tangyuan0821 commented Feb 16, 2026

Summary

  • Replace dead/unreliable URLs: musi‑cal.comhttps://www.python.org, requestb.inhttps://httpbin.org/post
  • Fix doc issues: ProxyHandler({}}) ProxyHandler({}), correct urlretrieve indentation
  • Switch applicable examples to HTTPS — docs-only change in urllib.request.rst

📚 Documentation preview 📚: https://cpython-previews--144863.org.readthedocs.build/en/144863/library/urllib.request.html

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented Feb 16, 2026

All commit authors signed the Contributor License Agreement.

CLA signed

Comment thread Doc/library/urllib.request.rst Outdated
Comment thread Doc/library/urllib.request.rst Outdated
Comment thread Doc/library/urllib.request.rst Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 6, 2026
Copy link
Copy Markdown
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@orsenthil orsenthil added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels May 31, 2026
@read-the-docs-community
Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32919793 | 📁 Comparing 67bbe40 against main (61ec3c2)

  🔍 Preview build  

1 file changed
± library/urllib.request.html

@orsenthil orsenthil merged commit 0f1f7c7 into python:main May 31, 2026
36 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs May 31, 2026
@miss-islington-app
Copy link
Copy Markdown

Thanks @tangyuan0821 for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 31, 2026

GH-150642 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label May 31, 2026
@miss-islington-app
Copy link
Copy Markdown

Sorry, @tangyuan0821 and @orsenthil, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0f1f7c7889873deb7c2e2c3f18695bf636e7752c 3.13

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 31, 2026

GH-150643 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label May 31, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 31, 2026

GH-150647 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 31, 2026
orsenthil added a commit that referenced this pull request May 31, 2026
…H-144863) (#150642)

gh-141444:fix broken URLs and examples in urllib.request.rst (GH-144863)

* Doc: fix broken URLs and examples in urllib.request.rst (gh-141444)

* Doc: update urllib.request examples to handle gzip compression

---------
(cherry picked from commit 0f1f7c7)

Co-authored-by: Paper Moon <tangyuan0821@email.cn>
Co-authored-by: Senthil Kumaran <senthil@python.org>
orsenthil added a commit that referenced this pull request May 31, 2026
…H-144863) (#150643)

gh-141444:fix broken URLs and examples in urllib.request.rst (GH-144863)

* Doc: fix broken URLs and examples in urllib.request.rst (gh-141444)

* Doc: update urllib.request examples to handle gzip compression

---------
(cherry picked from commit 0f1f7c7)

Co-authored-by: Paper Moon <tangyuan0821@email.cn>
Co-authored-by: Senthil Kumaran <senthil@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news stale Stale PR or inactive for long period of time.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants