feat(kubernetes): checks for memory limits, memory requests, and image tag#11373
Open
Nikhilkumar2311 wants to merge 1 commit into
Open
feat(kubernetes): checks for memory limits, memory requests, and image tag#11373Nikhilkumar2311 wants to merge 1 commit into
Nikhilkumar2311 wants to merge 1 commit into
Conversation
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7630
Context
Previous PR #9353 attempted these checks but went stale due to metadata
formatting issues. This PR implements the same checks with correct metadata.
Changes
Added 3 new Kubernetes workload security checks:
core_memory_limits_set— Ensure memory limits are set on all containerscore_memory_requests_set— Ensure memory requests are set on all containerscore_image_tag_fixed— Ensure image tag is not set to Latest or BlankMetadata fixes from PR #9353 review
Testing
Unit tests included for all 3 checks covering PASS, FAIL, and no-pods scenarios.