Skip to content

chore(ui): add npm security audit skill#11329

Open
Alan-TheGentleman wants to merge 5 commits into
masterfrom
chore/npm-security-audit-agent
Open

chore(ui): add npm security audit skill#11329
Alan-TheGentleman wants to merge 5 commits into
masterfrom
chore/npm-security-audit-agent

Conversation

@Alan-TheGentleman
Copy link
Copy Markdown
Contributor

@Alan-TheGentleman Alan-TheGentleman commented May 22, 2026

Context

Follow-up from an internal npm supply-chain audit against https://github.com/lirantal/npm-security-best-practices. The goal is to keep the audit guidance reusable as a project skill and reduce local package-install side effects.

Description

  • Add prowler-npm-security-audit as a project skill under skills/ and register it in root/UI agent guidance.
  • Document that Prowler should not enable general UI dependency-update automation in Dependabot/Renovate; only security remediation should be considered.
  • Stop worktree startup from auto-running cd ui && pnpm install; it now prints the explicit install command instead.
  • Make UI git hook setup opt-in from postinstall, while preserving an explicit pnpm run setup:hooks command.
  • Update UI README hook setup instructions for both ui/ and monorepo-root contexts.

Steps to review

  1. Inspect skills/prowler-npm-security-audit/SKILL.md and confirm the audit scope/checklist matches the repo supply-chain policy.
  2. Inspect AGENTS.md and ui/AGENTS.md and confirm the skill is registered and auto-invoked for npm/pnpm package security work.
  3. Inspect .config/wt.toml and confirm worktree startup no longer runs UI package lifecycle scripts automatically.
  4. Inspect ui/scripts/postinstall.js and confirm git hooks are only installed when PROWLER_UI_SETUP_GIT_HOOKS=1 is set.
  5. Inspect ui/README.md and confirm manual hook setup commands are accurate from both ui/ and the monorepo root.
  6. Confirm no general UI Dependabot/Renovate dependency update automation is enabled by this PR.

Validation

  • ./skills/skill-sync/assets/sync.sh
  • node --check ui/scripts/postinstall.js
  • node --check ui/scripts/setup-git-hooks.js
  • git diff --check origin/master..HEAD
  • Commit hooks: UI Prettier, YAML checks, zizmor, TruffleHog
  • Judgment Day dual review: approved after README command-location fixes

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

UI (if applicable)

  • All issue/task requirements work as expected on the UI
  • Ensure new entries are added to ui/CHANGELOG.md

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Alan-TheGentleman Alan-TheGentleman requested review from a team as code owners May 22, 2026 10:32
@Alan-TheGentleman Alan-TheGentleman added the no-changelog Skip including change in changelog/release notes label May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@Alan-TheGentleman Alan-TheGentleman marked this pull request as draft May 22, 2026 10:36
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

🔒 Container Security Scan

Image: prowler-ui:3d435fa
Last scan: 2026-05-22 12:10:05 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 2
Total 2

2 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@Alan-TheGentleman Alan-TheGentleman changed the title chore(ui): harden npm package audit workflow chore(ui): add npm security audit skill May 22, 2026
@Alan-TheGentleman Alan-TheGentleman marked this pull request as ready for review May 22, 2026 12:15
@Alan-TheGentleman Alan-TheGentleman requested a review from a team as a code owner May 22, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/ui no-changelog Skip including change in changelog/release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant