Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes postcss-filter-plugins to work with PostCSS v8 and aligns dependency management with the request in #25 by making PostCSS a peer dependency, while also updating the project’s build/test/tooling to a simpler Node-based setup.
Changes:
- Migrates the plugin implementation to the PostCSS 8 plugin API (
postcssPlugin+prepare). - Moves PostCSS to
peerDependencies(and keeps it indevDependenciesfor local development/testing). - Replaces AVA-based tests with Node’s built-in test runner and refreshes repository metadata/docs.
Reviewed changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.js | Rewrites the plugin implementation for PostCSS 8 (new plugin API + duplicate filtering logic). |
| src/index.test.js | Adds a new Node node:test suite covering duplicate filtering behavior. |
| src/tests/index.js | Removes the previous AVA-based test suite. |
| README.md | Updates README formatting and examples (but still contains legacy PostCSS plugin API usage). |
| package.json | Switches to peerDependency for PostCSS, updates scripts/tooling, and changes published entry point to src/. |
| LICENSE | Adds MIT license text as LICENSE. |
| CHANGELOG.md | Normalizes markdown list formatting. |
| .node-version | Pins a Node major version for development. |
| .gitignore | Removes dist ignore since dist/ is no longer produced/used. |
| .editorconfig | Removes EditorConfig configuration. |
| .babelrc | Removes Babel configuration (no longer building dist/). |
| .all-contributorsrc | Removes all-contributors configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required a big change to work with v8.
Closes #25