fix: dropdown search crash#3799
Merged
Merged
Conversation
AnnMarieW
requested review from
KoolADE85,
T4rk1n,
camdecoster and
ndrezn
as code owners
Contributor
|
Good find! Could you double check linting? Once that's fixed, I'll approve and this can be merged. |
camdecoster
approved these changes
May 29, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3707
This fixes a virtualization issue introduced in Dash 4.1 for large searchable option lists with component labels.
react-window uses the row index as the default key. After filtering, the same index may point to a different option, causing stale component rows to be reused. With component labels rendered through ExternalWrapper, this could result in errors like:
Adding a stable
itemKeybased on the option value makes sure the rows are remounted correctly when the filtered options change.