Fix GH-22046: The unserialize function with Uri\WhatWg\Url leads to NULL pointer dereference when object serialized back#22058
Open
kocsismate wants to merge 2 commits into
Open
Fix GH-22046: The unserialize function with Uri\WhatWg\Url leads to NULL pointer dereference when object serialized back#22058kocsismate wants to merge 2 commits into
kocsismate wants to merge 2 commits into
Conversation
TimWolla
reviewed
May 16, 2026
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
As mentioned in the issue, this should get a general fix. But the patch LGTM if we decide for some reason not to fix this generally.
kocsismate
requested review from
DanielEScherzer,
Girgias,
NattyNarwhal,
SakiTakamachi,
adoy,
alexdowad,
arnaud-lb,
bukka,
derickr,
devnexen,
dstogov,
kamil-tekiela,
youkidearitai and
zeriyoshi
as code owners
github-actions
Bot
added
Extension: iconv
Extension: json
Extension: ldap
Extension: libxml
Extension: mbstring
Extension: mysqli
Extension: mysqlnd
Extension: odbc
Extension: opcache
Extension: pcntl
Extension: pcre
Extension: pdo (core)
Extension: pdo_dblib
Extension: pdo_firebird
Extension: pdo_mysql
Extension: pdo_odbc
Extension: pdo_pgsql
Extension: pdo_sqlite
Extension: pgsql
Extension: phar
Extension: posix
Extension: readline
Extension: reflection
Extension: session
Extension: shmop
Extension: simplexml
labels
iluuu1994
reviewed
May 31, 2026
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
IMO, fuzzing-style issues (things that are effectively impossible to happen by accident) should be fixed on master, assuming they don't pose a security risk (which this does not).
Member
Author
Yes, I think you are right! So I changed the target branch to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unserializing from the "C" format is explicitly disabled.