trace: encode non-finite floats in auto telemetry JSON#8364
Open
immanuwell wants to merge 1 commit into
Open
Conversation
70b961d to
4b16e07
Compare
Collaborator
|
This comes up when using opentelemetry-go-instrumentation, right? Can you open a bug describing how you encountered this? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8364 +/- ##
=====================================
Coverage 82.9% 82.9%
=====================================
Files 314 314
Lines 25087 25114 +27
=====================================
+ Hits 20801 20826 +25
+ Misses 3912 3910 -2
- Partials 374 378 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a tiny footgun in auto trace telemetry.
When an auto span has a float attribute like
math.Inf(1),json.Marshalrejects it.autoSpan.endignored that error, so the emitted span buffer wasnil. Kinda bad: the span just disappears.Repro on
origin/main:A focused test fails with
span data was dropped.This PR encodes non-finite doubles as protobuf JSON strings:
NaN,Infinity,-Infinity, and decodes them too.Checked: