Skip to content

build: build codecache and snapshot with libnode #63626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
legendecas wants to merge 5 commits into
base: main
Choose a base branch
from
+152 −103
Open

build: build codecache and snapshot with libnode #63626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e880392
build: build codecache and snapshot with libnode
legendecas May 26, 2026
1b0519f
fixup! build: build codecache and snapshot with libnode
legendecas May 28, 2026
da0cc2f
fixup! build: build codecache and snapshot with libnode
legendecas May 29, 2026
1fabe7a
fixup! build: build codecache and snapshot with libnode
legendecas May 29, 2026
ae57f51
fixup! build: build codecache and snapshot with libnode
legendecas May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1818,7 +1818,7 @@ def configure_node_lib_files(o):
o['variables']['node_library_files'] = SearchFiles('lib', 'js')

def configure_node_cctest_sources(o):
o['variables']['node_cctest_sources'] = [ 'src/node_snapshot_stub.cc' ] + \
o['variables']['node_cctest_sources'] = [] + \
SearchFiles('test/cctest', 'cc') + \
SearchFiles('test/cctest', 'h')

Expand Down Expand Up @@ -1886,10 +1886,6 @@ def configure_node(o):
o['variables']['arm_fpu'] = options.arm_fpu or 'neon'

if options.node_snapshot_main is not None:
if options.shared:
# This should be possible to fix, but we will need to refactor the
# libnode target to avoid building it twice.
error('--node-snapshot-main is incompatible with --shared')
if options.without_node_snapshot:
error('--node-snapshot-main is incompatible with ' +
'--without-node-snapshot')
Expand All @@ -1900,17 +1896,15 @@ def configure_node(o):
if options.without_node_snapshot or options.node_builtin_modules_path:
o['variables']['node_use_node_snapshot'] = 'false'
else:
o['variables']['node_use_node_snapshot'] = b(
not cross_compiling and not options.shared)
o['variables']['node_use_node_snapshot'] = b(not cross_compiling)
Copy link
Copy Markdown
Member

@joyeecheung joyeecheung May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking but a couple of lines above, there's also another guard that errors out on --shared for node_snapshot_main, which I think is also fixed by this PR and can be removed?

Copy link
Copy Markdown
Member Author

@legendecas legendecas May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically yeah, but I haven't tested with node_snapshot_main. Will give it a shot.


# Do not use code cache when Node.js is built for collecting coverage of itself, this allows more
# precise coverage for the JS built-ins.
if options.without_node_code_cache or options.without_node_snapshot or options.node_builtin_modules_path or options.coverage:
o['variables']['node_use_node_code_cache'] = 'false'
else:
# TODO(refack): fix this when implementing embedded code-cache when cross-compiling.
o['variables']['node_use_node_code_cache'] = b(
not cross_compiling and not options.shared)
o['variables']['node_use_node_code_cache'] = b(not cross_compiling)

if options.write_snapshot_as_array_literals is not None:
o['variables']['node_write_snapshot_as_array_literals'] = b(options.write_snapshot_as_array_literals)
Expand Down
Loading
Loading