Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions lib/prepare_security.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,9 @@ export default class PrepareSecurityRelease extends SecurityRelease {
}
const createVulnerabilitiesJSON = await this.promptVulnerabilitiesJSON();

let securityReleasePRUrl;
const content = await this.buildDescription(releaseDate, securityReleasePRUrl);
const content = await this.buildDescription(releaseDate);
if (createVulnerabilitiesJSON) {
securityReleasePRUrl = await this.startVulnerabilitiesJSONCreation(
await this.startVulnerabilitiesJSONCreation(
releaseDate, content, excludedReports);
}

Expand Down Expand Up @@ -322,11 +321,9 @@ export default class PrepareSecurityRelease extends SecurityRelease {

const supportedVersions = await getSupportedVersions();

let asking = true;
while (asking) {
while (true) {
const dep = await promptDependencies(this.cli);
if (!dep) {
asking = false;
break;
}

Expand Down
2 changes: 1 addition & 1 deletion lib/security-release/security-release.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export async function pickReport(report, { cli, req }) {
});

let prURL = '';
let patchAuthors = [];
let patchAuthors;
if (custom_field_values.data.length) {
prURL = custom_field_values.data[0].attributes.value;
const { user } = await req.getPullRequest(prURL);
Expand Down
2 changes: 1 addition & 1 deletion lib/update-v8/minorUpdate.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ async function applyPatch(ctx, latestStr) {
} catch (e) {
const file = path.join(ctx.nodeDir, `${latestStr}.diff`);
await fs.writeFile(file, diff);
throw new Error(`Could not apply patch.\n${e}\nDiff was stored in ${file}`);
throw new Error(`Could not apply patch.\n${e}\nDiff was stored in ${file}`, { cause: e });
}
}

Expand Down
4 changes: 2 additions & 2 deletions lib/update-v8/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ export async function getNodeV8Version(cwd) {
: `${this.major}.${this.minor}.${this.build}`;
}
};
} catch (e) {
throw new Error('Could not find V8 version');
} catch (cause) {
throw new Error('Could not find V8 version', { cause });
}
};

Expand Down
Loading
Loading