fix(web): use base URL for synthetic page assets#811
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Page HTML rendering now uses a new Tests in Reviewed by Cursor Bugbot for commit ba42722. Bugbot is set up for automated code reviews on this repo. Configure here. |
AugustinMauroy
left a comment
There was a problem hiding this comment.
look at preview root link it's just broke
|
Updated this so synthetic pages use |
|
just open https://api-docs-tooling-git-fork-herrtian-fix-synthetic-f9f8be-openjs.vercel.app/ on your browser and see oh broken css url |
01cb39d to
ba42722
Compare
|
The branch synced now and the latest preview points the root page stylesheet at /styles.css. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ba42722. Configure here.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #811 +/- ##
==========================================
+ Coverage 82.80% 82.86% +0.06%
==========================================
Files 171 171
Lines 14904 14957 +53
Branches 1305 1312 +7
==========================================
+ Hits 12341 12394 +53
+ Misses 2555 2554 -1
- Partials 8 9 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|

Fixes #809
Uses the configured base URL for synthetic page asset roots, so the 404 page can be served from deep links without resolving CSS and JS relative to the missing path.
Checks: