reexec: add context-aware entrypoints and Dispatch#218
Open
thaJeztah wants to merge 1 commit into
Open
Conversation
thaJeztah
force-pushed
the
contextualize
branch
from
ce69b51 to
4f29c3a
Compare
Follow-up to 7aa8514; allow entrypoints to be invoked with a context and to return an error; - Add RegisterContext to register context-aware entrypoints. - Add Dispatch and DispatchContext, both returning (handled, error). - Init is kept for backward compatibility or cases where context or errors don't have to be handled. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
contextualize
branch
from
4f29c3a to
fe1a46a
Compare
thaJeztah
commented
Apr 17, 2026
kolyshkin
reviewed
May 29, 2026
| return dispatch(context.Background()) | ||
| } | ||
|
|
||
| // DispatchContext is like [Dispatch] but includes a context. |
Collaborator
There was a problem hiding this comment.
Since it's a new function, maybe
- remove context-less version entirely;
- rename the context-ful version to
Dispatch.
kolyshkin
reviewed
May 29, 2026
|
|
||
| if ok, err := reexec.DispatchContext(context.Background()); ok { | ||
| if err != nil { | ||
| _, _ = fmt.Fprintln(os.Stderr, "entrypoint failed:", err) |
Collaborator
There was a problem hiding this comment.
nit: is _, _ = really needed here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to 7aa8514; allow entrypoints to be invoked with a context and to return an error;