Skip to content

Add MIGraphX execution provider support#2165

Open
aditya-dl wants to merge 1 commit into
microsoft:mainfrom
aditya-dl:amd/dev/adilohia/migraphx_support
Open

Add MIGraphX execution provider support#2165
aditya-dl wants to merge 1 commit into
microsoft:mainfrom
aditya-dl:amd/dev/adilohia/migraphx_support

Conversation

@aditya-dl
Copy link
Copy Markdown

Add MIGraphX (AMD GPU) execution provider support to ONNX Runtime GenAI. The provider is exposed as "migraphx" to users (with "MIGraphXExecutionProvider" accepted as a catalog-name alias for compatibility with Windows ML EP discovery flows).

This PR supersedes #2093 (which used the now-reverted "AMDGPU" naming).

Changes:

  • Create src/migraphx/session_options.{h,cpp} with AppendExecutionProvider that tries V2 plugin path ("MIGraphXExecutionProvider") then falls back to V1 legacy API ("MIGraphX")
  • Add provider name normalization: both "migraphx" and "MIGraphXExecutionProvider" map to "MIGraphX"; register "MIGraphX" in the dispatch table
  • Enable graph capture for MIGraphX to allow compiled graph reuse during token generation
  • Add static input shape padding (prompt_gen_ flag) so MIGraphX avoids recompilation on varying prompt lengths. Gated behind NeedsStaticInputShapes() so it only activates for MIGraphX, not other EPs
  • Fix input_ids padding to handle both int32 and int64 element types, and correct per-row copy for batch_size > 1
  • Fix position_ids padding to prevent out-of-bounds read on next_tokens when tensor shape is padded to max_length for batch_size > 1

Configuration:

"provider_options": [{ "migraphx": {} }]

or

config.append_provider("migraphx")

Also accepted: "MIGraphXExecutionProvider" (catalog form, what Windows ML returns from the EP discovery API).

Known limitations:

  • Beam search not supported (requires past_present_share_buffer=true which requires num_beams=1)
  • Inputs allocated on CPU; the MIGraphX EP handles CPU↔GPU transfers internally

Copilot AI review requested due to automatic review settings May 14, 2026 19:37
@aditya-dl aditya-dl requested a review from a team as a code owner May 14, 2026 19:37
@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

@aditya-dl please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@aditya-dl
Copy link
Copy Markdown
Author

@kunal-vaishnavi @baijumeswani could you help review this PR?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds MIGraphX (AMD GPU) execution provider integration to ONNX Runtime GenAI, including provider name normalization and runtime behaviors needed to avoid recompilation during prompt processing.

Changes:

  • Register MIGraphX in the session-options dispatch table and add a MIGraphX EP implementation (V2 plugin path with V1 fallback).
  • Normalize provider names so "migraphx" and "MIGraphXExecutionProvider" map to "MIGraphX", and enable graph capture for MIGraphX.
  • Add “static input shape” prompt-time padding and update position/logits shapes to support padded prompt lengths.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
src/models/session_options.cpp Adds MIGraphX EP registration in the provider dispatch map.
src/models/position_inputs.h Updates CreateAndInitializePositionIDs signature to accept actual seq_length.
src/models/position_inputs.cpp Implements position id initialization w/ padded shapes and safe indexing using seq_length.
src/models/model.h Adds State::prompt_gen_ flag to control prompt-time padding behavior.
src/models/model.cpp Pads input_ids to max_length during prompt generation for static-shape EPs.
src/models/logits.cpp Forces logits output shape to max_length during prompt generation.
src/migraphx/session_options.h Declares MIGraphX EP append entrypoint.
src/migraphx/session_options.cpp Implements MIGraphX EP append with V2 plugin-first and V1 fallback.
src/generators.h Adds use_static_input_shapes to generator params.
src/generators.cpp Toggles prompt_gen_ around prompt vs token-generation runs.
src/config.h Declares NeedsStaticInputShapes.
src/config.cpp Adds MIGraphX name normalization, enables graph capture for MIGraphX, and implements NeedsStaticInputShapes.
cmake/global_variables.cmake Adds MIGraphX sources to the CMake glob.

Comment thread src/models/position_inputs.h
Comment thread src/models/model.cpp
Comment thread src/models/model.cpp
Comment thread src/models/model.cpp
Comment thread src/models/model.cpp
Comment thread src/models/model.cpp Outdated
Comment thread src/models/model.cpp
Comment thread src/models/position_inputs.cpp
Comment thread src/models/position_inputs.cpp
Comment thread src/models/position_inputs.cpp
@aditya-dl aditya-dl force-pushed the amd/dev/adilohia/migraphx_support branch from c947215 to c2f4145 Compare May 14, 2026 19:56
Add MIGraphX (AMD GPU) execution provider support to ONNX Runtime
GenAI. The provider is exposed as "migraphx" to users; OGA also
accepts "MIGraphXExecutionProvider" (the catalog form used by the
AMD-shipped Windows ML EP MSIX) so test harnesses that match
config strings against WinML-discovered names work without bypass
hacks.

Changes:
- Create src/migraphx/session_options.{h,cpp} with
  AppendExecutionProvider that tries V2 plugin path
  ("MIGraphXExecutionProvider") then falls back to V1 legacy API
  ("MIGraphX")
- Add provider name normalization: both "migraphx" and
  "MIGraphXExecutionProvider" map to "MIGraphX"; register in the
  dispatch table
- Enable graph capture for MIGraphX to allow compiled graph reuse
  during token generation
- Add static input shape padding (prompt_gen_ flag) so MIGraphX
  avoids recompilation on varying prompt lengths. Gated behind
  NeedsStaticInputShapes() to only activate for MIGraphX, not
  other EPs
- Fix input_ids padding to handle both int32 and int64 element
  types, and correct per-row copy for batch_size > 1
- Fix position_ids padding to prevent out-of-bounds read on
  next_tokens when tensor shape is padded to max_length for
  batch_size > 1

Configuration:
  "provider_options": [{ "migraphx": {} }]
  or: config.append_provider("migraphx")
  also accepted: "MIGraphXExecutionProvider" (catalog form)

Known limitations:
- Beam search not supported (requires past_present_share_buffer=true
  which requires num_beams=1)
- Inputs allocated on CPU; the MIGraphX EP handles CPU<->GPU
  transfers internally
@aditya-dl aditya-dl force-pushed the amd/dev/adilohia/migraphx_support branch from c2f4145 to d563801 Compare May 14, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants