Split config file#505
Open
Bslabe123 wants to merge 1 commit into
Open
Conversation
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
size/XXL
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Bslabe123
added a commit
to Bslabe123/inference-perf
that referenced
this pull request
May 28, 2026
Adds 56 unit tests covering the config package introduced in kubernetes-sigs#505: top-level config read and deep-merge, common distributions, and per-package validation for apis, loadgen, client (storage and server_metrics), the datagen data block, and reportgen. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bslabe123
added a commit
to Bslabe123/inference-perf
that referenced
this pull request
May 28, 2026
Adds 56 unit tests covering the config package introduced in kubernetes-sigs#505: top-level config read and deep-merge, common distributions, and per-package validation for apis, loadgen, client (storage and server_metrics), the datagen data block, and reportgen.
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achandrasekar, Bslabe123 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE:
Splits the 792-line inference_perf/config.py into per-subsystem modules under inference_perf/config/ (datagen, loadgen, reportgen, client/{modelserver,filestorage,server_metrics}, metrics, apis, utils), each as a config.py inside its own directory so it can grow into siblings without restructuring later. This mirrors the runtime tree so the config surface for a subsystem lives next to its other concerns. Keeps the public import path stable via inference_perf/config/init.py re-exports so no call sites had to change.