fix: make mkdocs CLI exception test reach prepare_docs#4867
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: immanuwell The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @immanuwell! |
|
Hi @immanuwell. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind test
What this PR does / why we need it:
Tiny MkDocs CLI test fix. The exception-path test mocked
prepare_docs, but then ranmain()without a temp--docs-dir, so it bailed on missingsite-srcbefore the mock was reached. Oops, test never hit the thing it said it was testing.Repro on
origin/main:PYTHONPATH=hack python -m unittest discover -s hack/mkdocs/__tests__ -p 'test_cli.py' -k test_main_handles_prepare_docs_exceptionsBefore:
AssertionError: Exception not raised.After: the test reaches the mocked
prepare_docsand passes. No cloud/API limits or quotas involved here; this is just local CLI arg handling.Which issue(s) this PR fixes:
None. Related to #3999 and #3860.
Does this PR introduce a user-facing change?: