Skip to content

docs(subnet-discovery): mention manual subnet annotations#4707

Open
alliasgher wants to merge 1 commit into
kubernetes-sigs:mainfrom
alliasgher:docs-subnet-manual-config
Open

docs(subnet-discovery): mention manual subnet annotations#4707
alliasgher wants to merge 1 commit into
kubernetes-sigs:mainfrom
alliasgher:docs-subnet-manual-config

Conversation

@alliasgher
Copy link
Copy Markdown

Issue

Fixes #3776

Description

The subnet auto-discovery guide currently doesn't mention that subnets can be set explicitly via annotations, so users who want to override discovery (the original reporter's case: limiting an LB to specific subnets) have to dig through both the Ingress and Service annotation pages to find the right option.

This adds a short "Manual override" tip box at the top of the page with direct links to:

  • `alb.ingress.kubernetes.io/subnets` (Ingress annotation reference)
  • `service.beta.kubernetes.io/aws-load-balancer-subnets` (Service annotation reference)

…and notes that setting either annotation skips auto-discovery entirely.

The other half of the issue (a unified, searchable annotation list) is a larger docs restructuring; this PR only addresses the discoverability problem the reporter explicitly called out.

Checklist

  • Added/modified documentation as required (such as the `README.md`, or the `docs` directory)
  • Made sure the title of the PR is a good description that can go into the release notes

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 25, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alliasgher
Once this PR has been reviewed and has the lgtm label, please assign zac-nixon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @alliasgher!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 25, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @alliasgher. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 25, 2026
Adds a note at the top of the subnet auto-discovery guide pointing
readers at the per-Ingress and per-Service annotations they can use to
pin a load balancer to a specific subnet set, with links to the
annotation reference in each guide.

Auto-discovery is a sensible default but readers landing on this page
when they want to override it currently have to dig through both the
Ingress and Service annotation pages to find the option. This makes the
escape hatch discoverable from the page they're already on.
@alliasgher alliasgher force-pushed the docs-subnet-manual-config branch from 0b0e133 to b30832f Compare April 25, 2026 15:56
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent annotation documentation for k8s service objects

2 participants