Skip to content

chore(lint): enable gci+gofumpt and fix violations#757

Open
alexandear wants to merge 1 commit into
kenn-io:mainfrom
alexandear-org:chore/gofumpt
Open

chore(lint): enable gci+gofumpt and fix violations#757
alexandear wants to merge 1 commit into
kenn-io:mainfrom
alexandear-org:chore/gofumpt

Conversation

@alexandear
Copy link
Copy Markdown

@alexandear alexandear commented May 28, 2026 •
edited
Loading

  • Enable gci and gofumpt formatters in .golangci.yml
  • Run golangci-lint fmt to automatically fix formatting issues.
  • Perform self-review and manually fix comments that are wrongly placed in the imports section.

Discovered this project from ArdanLabs' webinar "Practical Go Development with AI Agents".

@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 28, 2026

roborev: Combined Review (c58e85e)

Clean: all review agents found no Medium, High, or Critical issues.

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@alexandear alexandear changed the title chore(lint): enable gofumpt and fix violations chore(lint): enable gci+gofumpt and fix violations May 28, 2026
@alexandear alexandear force-pushed the chore/gofumpt branch 5 times, most recently from 316a01a to 3ce58b7 Compare May 28, 2026 14:47
@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 28, 2026

roborev: Combined Review (3ce58b7)

Clean: all agents reported no medium-or-higher issues.

The reviewed changes appear limited to enabling gci/gofumpt and applying formatting-only updates across the Go codebase.

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

@wesm
Copy link
Copy Markdown
Member

wesm commented May 29, 2026

Looks good, will merge when green

@alexandear
Copy link
Copy Markdown
Author

alexandear commented May 29, 2026

Looks good, will merge when green

Resolved conflicts

@roborev-ci
Copy link
Copy Markdown

roborev-ci Bot commented May 29, 2026

roborev: Combined Review (2c7af9c)

No Medium, High, or Critical issues found across the reviews.

Both agents reported the changes as clean.

Synthesized from 2 reviews (agents: codex | types: default, security)

mariusvniekerk
mariusvniekerk reviewed May 29, 2026
View reviewed changes
Comment thread cmd/roborev/integration_test_helpers.go
}

func gitRevParse(t *testing.T, dir string, ref string) string {
func gitRevParse(t *testing.T, dir, ref string) string {
Copy link
Copy Markdown
Collaborator

@mariusvniekerk mariusvniekerk May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of gofumpt making these changes. the prior one was clearer and will be what the agents write 100% of the time automatically.

Copy link
Copy Markdown
Author

@alexandear alexandear May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I revert these changes?

@wesm wesm mentioned this pull request May 29, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusvniekerk mariusvniekerk mariusvniekerk left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexandear @wesm @mariusvniekerk