fix: preserve nontransparent live resumption#5676
Conversation
0862fa5 to
40d1f38
Compare
39cad79 to
cf3a10c
Compare
|
Hi @he-yufeng ,Thank you for your contribution! We appreciate you taking the time to submit this pull request. Please fix formatting errors by running autoformat.sh |
735c935 to
69033ca
Compare
|
Rebased onto current Validation: The previous failure was the pre-commit formatting check; this branch is now a single commit on current main. |
69033ca to
b4e1565
Compare
|
Rebased this onto current Validation: |
b4e1565 to
0d359a6
Compare
|
Rebased onto current main again; no code changes beyond the rebase.\n\nValidation on Windows:\n- uv run --no-sync pytest tests\unittests\flows\llm_flows\test_base_llm_flow.py -q --basetemp .tmp\pytest-5676-20260524 -p no:cacheprovider -> 31 passed, 1 existing experimental warning\n- uv run --no-sync pyink --check src\google\adk\flows\llm_flows\base_llm_flow.py tests\unittests\flows\llm_flows\test_base_llm_flow.py\n- uv run --no-sync python -m py_compile src\google\adk\flows\llm_flows\base_llm_flow.py tests\unittests\flows\llm_flows\test_base_llm_flow.py\n- git diff --check upstream/main..HEAD |
|
Rebased onto current main and force-pushed fe58e74. Local validation: py_compile passed; focused live reconnection regression test passed; pyink, isort, and git diff --check passed. |
0d359a6 to
fe58e74
Compare
|
Hi @he-yufeng , could you please resolve the branch conflicts. |
fe58e74 to
d6a117f
Compare
|
Rebased onto current main and resolved the live resumption conflict. I kept upstream's Vertex-only transparent=True behavior and preserved this branch's existing-session-resumption regression coverage. Validation on Windows: uv run --no-sync pytest tests\unittests\flows\llm_flows\test_base_llm_flow.py -q --basetemp .tmp\pytest-5676-20260530 -p no:cacheprovider -> 35 passed, 5 warnings; uv run --no-sync pyink src\google\adk\flows\llm_flows\base_llm_flow.py tests\unittests\flows\llm_flows\test_base_llm_flow.py --check; uv run --no-sync python -m py_compile src\google\adk\flows\llm_flows\base_llm_flow.py tests\unittests\flows\llm_flows\test_base_llm_flow.py; git diff --check upstream/main..HEAD. |
Summary
Fixes #5675.
BaseLlmFlow.run_livealways setsession_resumption.transparent = Truewhen reconnecting with a saved live-session handle. That overwrote an explicittransparent=Falseconfig, which is the configuration needed for direct Gemini API live-session resumption becauseGoogleLLM.connectrejects transparent resumption on the Gemini API backend.This keeps the existing default behavior for reconnects that have no session resumption config yet, but preserves a caller-provided non-transparent config.
Validation