Spelling fixes (re-opened from #1330, hi/ rename dropped)#1334
Conversation
…xperience is important Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR applies spelling and wording fixes from the earlier localization-related PR while intentionally excluding the Hindi folder move that caused link-check failures.
Changes:
- Corrects duplicated wording in vendored
primer-boxdocumentation. - Updates contribution instructions and bug-report wording.
- Improves attribution and link text for the recommended article in
CONTRIBUTING.md.
Show a summary per file
| File | Description |
|---|---|
node_modules/primer-box/README.md |
Fixes duplicated “a” in the Box component description. |
CONTRIBUTING.md |
Updates translation guidance, simplifies bug-report wording, and improves article attribution. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/2 changed files
- Comments generated: 1
The previous 'Fix localization instructions' commit updated the path from the repo root to _articles/ but didn't remove the trailing 'the repository root' fragment, leaving the sentence reading as if the new folder belonged in both places. The line about copying source files had a similar the English source files live atissue _articles/businesses.html etc., not at the repo root. Addresses Copilot review feedback on PR #1334. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Addressed in b5da167. The While I was in there, I also fixed the same class of bug on line 22 — the English source files actually live at Verified the build + HTMLProofer (55 files, all green). |
Re-opens the spelling-only commits from #1330 from a local branch so CodeQL runs (fork PRs don't get CodeQL coverage in this repo, leaving #1330 permanently
BLOCKEDeven when tests pass).Cherry-picked four of the five commits from #1330, all authored by @jsoref:
link: Shubheksha Jalan's credit the article author inCONTRIBUTING.mdgreatarticleFix localization point translators to_articles/(where 16/17 locales actually live)instructionsa whitein vendorednode_modules/primer-box/README.mdplease provideinCONTRIBUTING.md_articles/hi/rename). That commit causes 22 HTMLProofer failures because the existing language-switcher links across all other locales resolve to/hi/...via Jekyll's default routing of the root-levelhi/folder; moving the files under_articles/hi/without additional permalink/collection routing breaks those links. Worth fixing see the comment I left on #1330.separatelyCloses #1330.
Co-authored-by: Josh Soref 2119212+jsoref@users.noreply.github.com