fix: add preflight checks and protect release notes from URL redaction#1513
Closed
edburns wants to merge 4 commits into
Closed
fix: add preflight checks and protect release notes from URL redaction#1513edburns wants to merge 4 commits into
edburns wants to merge 4 commits into
Conversation
modified: .github/aw/actions-lock.json modified: .github/workflows/java.notes.template modified: .github/workflows/release-changelog.lock.yml modified: .github/workflows/release-changelog.md Try to fix the 📦 [View on Maven Central]((central.sonatype.com/redacted) problem.
modified: .github/workflows/java-publish-maven.yml - Add a preflight to try to avoid failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Preflight job in
java-publish-maven.yml: validatesJAVA_RELEASE_TOKEN(push access) andJAVA_RELEASE_GITHUB_TOKEN(workflow dispatch access) before runningpublish-mavenorgithub-release. If either token is invalid, the entire pipeline stops.Release notes template (
java.notes.template): added HTML comment markers (INSTALLATION_SECTION/END_INSTALLATION_SECTION) and amaven_central_urlcomment so the changelog generator can preserve and reconstruct the Maven Central URL if the firewall proxy redacts it.Changelog generator (
release-changelog.md): added Step 6 instructions to preserve the Installation section verbatim and reconstruct the Maven Central URL if corrupted.Fixes the
(central.sonatype.com/redacted)issue seen on java/v1.0.0-beta-10-java.4.