Skip to content

📝 Simplify error message for non-existent user in password recovery#2310

Closed
Musbi8788 wants to merge 1 commit into
fastapi:masterfrom
Musbi8788:master
Closed

📝 Simplify error message for non-existent user in password recovery#2310
Musbi8788 wants to merge 1 commit into
fastapi:masterfrom
Musbi8788:master

Conversation

@Musbi8788
Copy link
Copy Markdown

@Musbi8788 Musbi8788 commented May 26, 2026

This PR improve the error message on the login.py for better UX

Updated the response message from:

  • "The user with this username does not exist in the system."
    to:
  • "User does not exist"

This makes the reponse shoter and remove unnessary message like ".... username don't exit in the system" for better security with telling fake users that the name don't exist in the system instead we can just tell them the user does not exist.

Checklist

  • This PR is an obvious typo fix, or it links to a GitHub Discussion for the proposed code change.
  • I added tests for the change.
  • The new or updated tests fail on the main branch and pass on this PR.
  • Coverage stays at 100%.
  • The documentation explains the change if needed.

@Musbi8788 Musbi8788 marked this pull request as draft May 26, 2026 00:55
@Musbi8788 Musbi8788 marked this pull request as ready for review May 26, 2026 00:55
@github-actions
Copy link
Copy Markdown
Contributor

This was marked as potentially AI generated and will be closed now. If this is an error, please provide additional details, make sure to read the docs about contributing and AI.

@github-actions github-actions Bot closed this May 28, 2026
@Musbi8788
Copy link
Copy Markdown
Author

This was marked as potentially AI generated and will be closed now. If this is an error, please provide additional details, make sure to read the docs about contributing and AI.

Thank you for this update am updating the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants