Skip to content

Align thunk gen formating with dotnet-format#128785

Open
am11 wants to merge 3 commits into
dotnet:mainfrom
am11:chore/thunk-gen-formatter
Open

Align thunk gen formating with dotnet-format#128785
am11 wants to merge 3 commits into
dotnet:mainfrom
am11:chore/thunk-gen-formatter

Conversation

@am11
Copy link
Copy Markdown
Member

@am11 am11 commented May 29, 2026

While working on new instructions, I noticed inconsistent formatting with dotnet-format. This PR updates the thunk generator so it produces properly formatted code from the get go.

@am11 am11 requested a review from MichalStrehovsky as a code owner May 29, 2026 21:50
@github-actions github-actions Bot added the area-crossgen2-coreclr only use for closed issues label May 29, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging @dotnet/jit-contrib for JIT-EE GUID update

@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label May 29, 2026
@am11 am11 requested review from EgorBo and jakobbotsch May 29, 2026 21:52
@am11
Copy link
Copy Markdown
Member Author

am11 commented May 29, 2026

Formatting pre-commit hook (#128649) makes this more painful to undo formatting changes. 😅

Comment thread src/coreclr/inc/jiteeversionguid.h Outdated
@am11
Copy link
Copy Markdown
Member Author

am11 commented May 30, 2026

Timeout issue is unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-crossgen2-coreclr only use for closed issues community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants