rockchip64: restore CONFIG_MOTORCOMM_PHY=y in current kernel config#9912
rockchip64: restore CONFIG_MOTORCOMM_PHY=y in current kernel config#9912rubycomm wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR enables the Motorcomm PHY driver across Rockchip64 kernel configs by adding ChangesMotorcomm PHY Support
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
If affected |
|
Please also run and check if the change persists. Else you might need to do further config changes related to get it stable. Menuconfig is your friend here |
|
✅ This PR has been reviewed and approved — all set for merge! |
Commit 3ce7dec ("Automatic: kernel config rewrite", 2026-05-04) inadvertently removed CONFIG_MOTORCOMM_PHY=y from config/kernel/linux-rockchip64-current.config, undoing the deliberate m -> y change introduced by 01c1825 ("rockchip64: rk3528: fix ethernet PHY detection on NanoPi Zero2 (6.18 + 7.0)", PR armbian#9597, merged 2026-03-26). Without MOTORCOMM_PHY built-in, the YT8531S PHY on the NanoPi Zero2 (and any other rockchip64-current board carrying a Motorcomm PHY) is not detected during MDIO bus probe because the driver loads as a module after the bus scan completes. PR armbian#9597's commit message documents the rationale: Also change CONFIG_MOTORCOMM_PHY from module (m) to built-in (y) in the rockchip64 kernel config, as a module the driver loads after the MDIO scan and the PHY isn't found at boot. Re-validated on NanoPi Zero2 hardware (2026-05-17): with this change, end0 links at 1000Mb/s Full and the YT8531S is detected at boot. Signed-off-by: Shlomi Marco <s.marco@rubycomm.com>
34c5b33 to
3dbe7c7
Compare
Apply the same restoration as 3dbe7c7 to the edge and bleedingedge kernel configs so all three rockchip64 branches carry the YT8531/YT8521 PHY driver, as requested in PR review.
rewrite removes it, so further diganosis is needed. |
|
A few more lines were removed back then, I assume those are necessary dependencies which causing removal on rewrite. |
Description
Commit 3ce7dec ("Automatic: kernel config rewrite", 2026-05-04) inadvertently
removed
CONFIG_MOTORCOMM_PHY=yfromconfig/kernel/linux-rockchip64-current.config, undoing the deliberatem -> ychange introduced by 01c1825 ("rockchip64: rk3528: fix ethernet PHY detection
on NanoPi Zero2", PR #9597, merged 2026-03-26).
Without
MOTORCOMM_PHYbuilt-in, the YT8531S PHY on the NanoPi Zero2 (and anyother rockchip64-current board carrying a Motorcomm PHY) is not detected during
the MDIO bus probe: as a module the driver loads after the bus scan completes,
so the PHY isn't found at boot. PR #9597's commit message documents this
rationale explicitly.
This patch re-adds the single line that was dropped.
How Has This Been Tested?
Re-validated on NanoPi Zero2 hardware (2026-05-17): with this change,
end0links at 1000Mb/s Full and the YT8531S is detected at boot.
Checklist
Summary by CodeRabbit