Skip to content

rockchip64: restore CONFIG_MOTORCOMM_PHY=y in current kernel config#9912

Open
rubycomm wants to merge 2 commits into
armbian:mainfrom
rubycomm:restore-motorcomm-phy-config
Open

rockchip64: restore CONFIG_MOTORCOMM_PHY=y in current kernel config#9912
rubycomm wants to merge 2 commits into
armbian:mainfrom
rubycomm:restore-motorcomm-phy-config

Conversation

@rubycomm
Copy link
Copy Markdown
Contributor

@rubycomm rubycomm commented May 29, 2026

Description

Commit 3ce7dec ("Automatic: kernel config rewrite", 2026-05-04) inadvertently
removed CONFIG_MOTORCOMM_PHY=y from
config/kernel/linux-rockchip64-current.config, undoing the deliberate m -> y
change introduced by 01c1825 ("rockchip64: rk3528: fix ethernet PHY detection
on NanoPi Zero2", PR #9597, merged 2026-03-26).

Without MOTORCOMM_PHY built-in, the YT8531S PHY on the NanoPi Zero2 (and any
other rockchip64-current board carrying a Motorcomm PHY) is not detected during
the MDIO bus probe: as a module the driver loads after the bus scan completes,
so the PHY isn't found at boot. PR #9597's commit message documents this
rationale explicitly.

This patch re-adds the single line that was dropped.

How Has This Been Tested?

Re-validated on NanoPi Zero2 hardware (2026-05-17): with this change, end0
links at 1000Mb/s Full and the YT8531S is detected at boot.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Summary by CodeRabbit

  • Chores
    • Enabled Motorcomm PHY support across affected kernel builds.
    • Result: Improved compatibility and more reliable Ethernet networking on boards using Motorcomm PHY devices, reducing setup issues.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0c73b118-b593-4eef-ba00-b05e3d44fe26

📥 Commits

Reviewing files that changed from the base of the PR and between 3dbe7c7 and 06ab411.

📒 Files selected for processing (2)
  • config/kernel/linux-rockchip64-bleedingedge.config
  • config/kernel/linux-rockchip64-edge.config
✅ Files skipped from review due to trivial changes (1)
  • config/kernel/linux-rockchip64-edge.config

📝 Walkthrough

Walkthrough

This PR enables the Motorcomm PHY driver across Rockchip64 kernel configs by adding CONFIG_MOTORCOMM_PHY=y to three generated config files.

Changes

Motorcomm PHY Support

Layer / File(s) Summary
Enable Motorcomm PHY driver in Rockchip64 configs
config/kernel/linux-rockchip64-current.config, config/kernel/linux-rockchip64-bleedingedge.config, config/kernel/linux-rockchip64-edge.config
Inserts CONFIG_MOTORCOMM_PHY=y into each Rockchip64 kernel configuration file to enable the Motorcomm PHY driver.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

Ready to merge

Suggested reviewers

  • HeyMeco
  • rpardini
  • TheSnowfield
  • ColorfulRhino
  • JohnTheCoolingFan
  • lanefu
  • pyavitz
  • Tonymac32

Poem

🐰 I nudged one line in the night,
CONFIG_MOTORCOMM_PHY shining bright,
Rockchip boards stretch their nets,
Tiny packets place their bets,
Hops and builds — a coder's delight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: restoring CONFIG_MOTORCOMM_PHY=y to the current kernel config for rockchip64, which is the primary modification across all three config files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added 05 Milestone: Second quarter release size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels May 29, 2026
@EvilOlaf
Copy link
Copy Markdown
Member

If affected edge and bleedingedge should be updated as well

@HeyMeco
Copy link
Copy Markdown
Collaborator

HeyMeco commented May 29, 2026

Please also run

./compile.sh rewrite-kernel-config BOARD=rnanopi-zero2 BRANCH=current

and check if the change persists. Else you might need to do further config changes related to get it stable. Menuconfig is your friend here

@github-actions github-actions Bot added the Ready to merge Reviewed, tested and ready for merge label May 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot removed the Needs review Seeking for review label May 29, 2026
Commit 3ce7dec ("Automatic: kernel config rewrite", 2026-05-04)
inadvertently removed CONFIG_MOTORCOMM_PHY=y from
config/kernel/linux-rockchip64-current.config, undoing the deliberate
m -> y change introduced by 01c1825 ("rockchip64: rk3528: fix
ethernet PHY detection on NanoPi Zero2 (6.18 + 7.0)", PR armbian#9597,
merged 2026-03-26).

Without MOTORCOMM_PHY built-in, the YT8531S PHY on the NanoPi Zero2
(and any other rockchip64-current board carrying a Motorcomm PHY) is
not detected during MDIO bus probe because the driver loads as a
module after the bus scan completes. PR armbian#9597's commit message
documents the rationale:

  Also change CONFIG_MOTORCOMM_PHY from module (m) to built-in (y) in
  the rockchip64 kernel config, as a module the driver loads after
  the MDIO scan and the PHY isn't found at boot.

Re-validated on NanoPi Zero2 hardware (2026-05-17): with this change,
end0 links at 1000Mb/s Full and the YT8531S is detected at boot.

Signed-off-by: Shlomi Marco <s.marco@rubycomm.com>
@igorpecovnik igorpecovnik force-pushed the restore-motorcomm-phy-config branch from 34c5b33 to 3dbe7c7 Compare May 29, 2026 22:51
@github-actions github-actions Bot added Ready to merge Reviewed, tested and ready for merge Needs review Seeking for review and removed Ready to merge Reviewed, tested and ready for merge labels May 29, 2026
Apply the same restoration as 3dbe7c7 to the edge and bleedingedge
kernel configs so all three rockchip64 branches carry the YT8531/YT8521
PHY driver, as requested in PR review.
@github-actions github-actions Bot removed the Ready to merge Reviewed, tested and ready for merge label May 29, 2026
@igorpecovnik
Copy link
Copy Markdown
Member

and check if the change persists.

rewrite removes it, so further diganosis is needed.

@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress and removed Needs review Seeking for review labels May 29, 2026
@EvilOlaf
Copy link
Copy Markdown
Member

A few more lines were removed back then, I assume those are necessary dependencies which causing removal on rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... size/small PR with less then 50 lines Work in progress Unfinished / work in progress

Development

Successfully merging this pull request may close these issues.

4 participants