Script Loader: Clarify the "invalid_filetype" upload error message#12017
Script Loader: Clarify the "invalid_filetype" upload error message#12017TPilgs wants to merge 1 commit into
Conversation
…types. The previous wording -- "This file cannot be processed by the web server" -- implied a server fault when the actual cause is that WordPress does not accept the file's MIME type. Match the convention used by neighboring strings in $uploader_l10n (e.g. zero_byte_file, not_an_image) so users understand the reason and the recommended action.
|
Hi @TPilgs! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
Tested using WordPress Playground, fix works as expected! 
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @TPilgs, @serabi. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2 participants
Trac ticket
https://core.trac.wordpress.org/ticket/65374
Summary
The
invalid_filetypeerror string inwp_default_scripts()(src/wp-includes/script-loader.php) currently reads:This implies a server fault when the actual cause is that WordPress does not accept the file's MIME type. The wording is also inconsistent with neighboring strings in the same
$uploader_l10narray, which all explain the cause and suggest an action:zero_byte_file: "This file is empty. Please try another."not_an_image: "This file is not an image. Please try another."Proposed change:
This pattern-matches the surrounding strings, removes the misleading "web server" framing, and tells the user what to do next.
Related
See also Trac #61361, which made the analogous wording improvement to the image-specific
noneditable_imagemessage for the same reason. Theinvalid_filetypestring was not touched in that ticket but suffers the same vagueness.