fix: reset static fields for Fast Enter Play Mode#3956
Merged
Conversation
# Conflicts: # com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs
noellie-velez
commented
Apr 24, 2026
noellie-velez
commented
Apr 24, 2026
noellie-velez
commented
Apr 24, 2026
simon-lemay-unity
approved these changes
Apr 24, 2026
Contributor
simon-lemay-unity
left a comment
simon-lemay-unity
left a comment
There was a problem hiding this comment.
Changes to UnityTransport look good to me.
# Conflicts: # com.unity.netcode.gameobjects/Runtime/Logging/NetworkLog.cs
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 11, 2026
noellie-velez
commented
May 21, 2026
EmandM
reviewed
May 25, 2026
Member
EmandM
left a comment
EmandM
left a comment
There was a problem hiding this comment.
This is looking incredible! You've done such good thorough work on this PR. You should be really proud of yourself. 
# Conflicts: # com.unity.netcode.gameobjects/CHANGELOG.md
noellie-velez
commented
May 29, 2026
Comment on lines
+12
to
+16
| #if UNITY_6000_6_OR_NEWER | ||
| [Scripting.LifecycleManagement.AutoStaticsCleanup] | ||
| #endif | ||
| [Serializable] | ||
| public static class NetworkVariableSerialization<T> | ||
| public static partial class NetworkVariableSerialization<T> |
Collaborator
Author
There was a problem hiding this comment.
This is breaking the tests on trunk. It seems AutoStaticsCleanup may be cleaning up after ILPP initialization.
@ShadauxCat, can you confirm whether we actually need to reset those statics?
…gies/com.unity.netcode.gameobjects into chore/fast-enter-playmode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Ensure com.unity.netcode.gameobjects package supports Fast Enter Play Mode
Jira ticket
MTT-14665
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
N/A