Skip to content

[Tests] Remove filesystem mocks in execute-command-helpers.test.ts#7675

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-remove-fs-mocks-execute-command-helpers-9343488799109230646
Draft

[Tests] Remove filesystem mocks in execute-command-helpers.test.ts#7675
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-remove-fs-mocks-execute-command-helpers-9343488799109230646

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

This PR follows the testing protocol specified in .agents/automated-tasks/tests.md which mandates using real files and directories in temporary directories instead of mocking the filesystem.

WHAT is this pull request doing?

Refactored packages/app/src/cli/utilities/execute-command-helpers.test.ts to:

  • Remove the global vi.mock('@shopify/cli-kit/node/fs').
  • Replace all mocked usages of readFile and fileExists with real filesystem operations using inTemporaryDirectory and writeFile from @shopify/cli-kit/node/fs.
  • Use joinPath from @shopify/cli-kit/node/path for cross-platform path handling.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 9343488799109230646 started by @gonzaloriestra

Updated `packages/app/src/cli/utilities/execute-command-helpers.test.ts` to remove `vi.mock('@shopify/cli-kit/node/fs')` and use real filesystem operations in temporary directories. This aligns the test file with the project's testing protocol of avoiding filesystem mocks.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant