[Tests] Remove filesystem mocks in execute-command-helpers.test.ts#7675
[Tests] Remove filesystem mocks in execute-command-helpers.test.ts#7675gonzaloriestra wants to merge 1 commit into
Conversation
Updated `packages/app/src/cli/utilities/execute-command-helpers.test.ts` to remove `vi.mock('@shopify/cli-kit/node/fs')` and use real filesystem operations in temporary directories. This aligns the test file with the project's testing protocol of avoiding filesystem mocks.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
This PR follows the testing protocol specified in
.agents/automated-tasks/tests.mdwhich mandates using real files and directories in temporary directories instead of mocking the filesystem.WHAT is this pull request doing?
Refactored
packages/app/src/cli/utilities/execute-command-helpers.test.tsto:vi.mock('@shopify/cli-kit/node/fs').readFileandfileExistswith real filesystem operations usinginTemporaryDirectoryandwriteFilefrom@shopify/cli-kit/node/fs.joinPathfrom@shopify/cli-kit/node/pathfor cross-platform path handling.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 9343488799109230646 started by @gonzaloriestra