Open auth browser without keypress prompt#7668
Draft
gonzaloriestra wants to merge 1 commit into
Draft
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
dmerand
reviewed
May 29, 2026
|
|
||
| if (isCloudEnvironment() || !isTTY()) { | ||
| cloudMessage() | ||
| const opened = await openURL(jsonResult.verification_uri_complete) |
Contributor
There was a problem hiding this comment.
Should we harden openURL to more reliably return false in cloud environments? I guess non-TTY isn't a good enough signal (agentic flows are non-TTY) but I'm wondering about situations where open may just hang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The login flow currently pauses in interactive terminals and asks users to press a key before Shopify CLI opens the browser. We want authentication to start directly by opening the browser, making it easier for agents.
WHAT is this pull request doing?
keypress()wait and "Press any key" message from the interactive device auth flow.How to test your changes?
shopify auth loginChecklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add