Skip to content

[Performance] Optimize unstyled function with early return for plain strings#7665

Closed
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-optimize-unstyled-5606380692926850082
Closed

[Performance] Optimize unstyled function with early return for plain strings#7665
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-optimize-unstyled-5606380692926850082

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The unstyled function is used frequently in the CLI to remove ANSI escape codes from strings, particularly during layout calculations and logging. Always calling stripAnsi (which uses a regular expression) even for plain strings introduces unnecessary overhead.

WHAT is this pull request doing?

Added an early return to the unstyled function in packages/cli-kit if the string does not contain the ANSI escape character (\u001b). This avoids the overhead of regex execution for plain strings.

Benchmark results for 1,000,000 iterations:

  • Plain strings: ~109ms (old) vs ~28ms (new) -> ~75% improvement.
  • ANSI strings: ~310ms (old) vs ~322ms (new) -> negligible overhead (~4%).

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 5606380692926850082 started by @gonzaloriestra

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant