[Performance] Optimize unstyled function with early return for plain strings#7665
[Performance] Optimize unstyled function with early return for plain strings#7665gonzaloriestra wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The
unstyledfunction is used frequently in the CLI to remove ANSI escape codes from strings, particularly during layout calculations and logging. Always callingstripAnsi(which uses a regular expression) even for plain strings introduces unnecessary overhead.WHAT is this pull request doing?
Added an early return to the
unstyledfunction inpackages/cli-kitif the string does not contain the ANSI escape character (\u001b). This avoids the overhead of regex execution for plain strings.Benchmark results for 1,000,000 iterations:
How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 5606380692926850082 started by @gonzaloriestra