[Tests] Remove filesystem mocks in app-logs-polling.test.ts#7644
[Tests] Remove filesystem mocks in app-logs-polling.test.ts#7644gonzaloriestra wants to merge 1 commit into
Conversation
Refactor packages/app/src/cli/services/dev/processes/app-logs-polling.test.ts to remove global vi.mock('@shopify/cli-kit/node/fs') and use real filesystem operations in temporary directories. Verified that tests pass.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Following the standardized approach for file system interactions in unit tests, this PR removes global filesystem mocks in
app-logs-polling.test.tsto improve test reliability and maintainability.WHAT is this pull request doing?
vi.mock('@shopify/cli-kit/node/fs')frompackages/app/src/cli/services/dev/processes/app-logs-polling.test.ts.inTemporaryDirectoryfrom@shopify/cli-kit/node/fsfor tests that trigger directory creation.fileExistsSyncon real paths instead of checking mock calls onmkdir.How to test your changes?
CI
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 9193237525126123010 started by @gonzaloriestra