Invalidate ordered map builder after entry value updates#253
Open
odenix wants to merge 1 commit into
Open
Conversation
This bug was found and fixed by Codex. PersistentOrderedMapBuilder caches the last built ordered map. Updating an entry through MutableMap.MutableEntry.setValue updated only the backing hash map builder, leaving the ordered builder cache incorrectly valid. A later build() could therefore return the previously built map. Route entry value updates through the ordered map builder so its existing cache invalidation path runs. Add a regression test that builds once before mutating an entry value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was found and fixed by Codex.
PersistentOrderedMapBuilder caches the last built ordered map. Updating an entry through MutableMap.MutableEntry.setValue updated only the backing hash map builder, leaving the ordered builder cache incorrectly valid. A later build() could therefore return the previously built map.
Route entry value updates through the ordered map builder so its existing cache invalidation path runs. Add a regression test that builds once before mutating an entry value.