[Interactive Graph] Wire pointLabels through special-shape graphs (angle, circle, absolute-value)#3697
Open
ivyolamit wants to merge 2 commits into
Conversation
…Interactive Graph] Wire pointLabels through special-shape graphs (angle, circle, absolute-value)
…] Wire pointLabels through special-shape graphs (angle, circle, absolute-value)
Contributor
|
Size Change: +141 B (+0.03%) Total Size: 506 kB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (23b781e) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3697If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3697If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3697 |
This was referenced May 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
pointLabelsthrough the three special-shape interactive graphs —angle,circle, andabsolute-value— closing out the LEMS-3995 rollout (PRs 1–6 already shipped).MovablePointnow announces its author-supplied label when set. Per-type fallbacks whenpointLabelsis unset, empty, or non-string:Co-Authored by Claude Code (Opus)
Issue: LEMS-3995
Test plan:
AngleWithCustomLabels/CircleWithCustomLabels/AbsoluteValueWithCustomLabelsstories. Enable the Storybook a11y addon (or VoiceOver / JAWS) and confirm each interactive handle announces "Point A / B / C / V / R at …" matching its prompt. Confirm the existing base stories still announce the per-type defaults. For circle, confirm the center's announcement ("Circle. The center point is at …") is NOT overridden even whenpointLabelsis set.InteractiveGraphAngle/InteractiveGraphCircle/InteractiveGraphAbsoluteValueeditor stories, expand "Start coordinates", and confirm each label field is present. For angle/absolute-value, the field sits inside the existingCoordInputtile. For circle, the field appears as a separate "Radius point label:" row at the bottom (only visible whenonChangePointLabelsis wired by the surroundinginteractive-graph-editor.tsx). Type a letter into each field and confirm the rendered graph's pointaria-labeland the Screen reader tree panel update on the same render.PR Series