[Explanation] Add more visual regression tests#3695
Open
mark-fitzgerald wants to merge 5 commits into
Open
Conversation
…fy the regression test stories to match current format. Add data and stories for content that includes images, videos, and tables.
…(changeset): [Explanation] Add more visual regression tests
…more visual regression tests for Explanation widget. Nested widget tests are moved to a new Nested Widgets folder to aid in centralizing such tests.
Contributor
|
Size Change: 0 B Total Size: 506 kB ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (ee2d4c2) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3695If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3695If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3695 |
…te changeset. Remove comment. Adjust data text.
…st content for Image in Content test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR expands the visual regression test coverage for the Explanation widget,
adding stories that cover embedded video, images, and data tables in explanation
content. It also adds interaction regression stories for hints renderer behavior,
and moves nested widget tests into a dedicated "Nested Widgets" folder to
centralize tests for widgets that contain other widgets.
Issue: LEMS-4130
Test plan:
with images, embedded video, and tables should display without visual
artifacts.
render correctly for both initial state and interactions.
regression story works as expected.