Skip to content

Commit 381be43

Browse files
trek-eCI Rebase Check
andauthored
fix(#445): upgrade Windows checkout v4→v5.0.1 + remove FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 (node20 EOL) (#446)
Problem: Node 20 deprecation warnings fired on every CI run. Despite FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true in test.yml (added in PR #350), the warning is not silenced — the env var only changes which warning fires (both paths call context.Warning()). The only silent path is for the action itself to declare `using: node24`. Ref: https://github.com/actions/runner/blob/main/src/Runner.Common/Util/NodeUtil.cs Ref: https://github.com/actions/runner/blob/main/src/Runner.Worker/JobExtension.cs Three locations used @v4 actions (node20 runtime): 1. test.yml — Windows lanes (test + test-full jobs) pinned to actions/checkout@11bd719 (v4.2.2). Original pin rationale (PR #162 / issue #161): v6 uses includeIf.gitdir: for auth injection, which is unreliable on Windows git 2.54. v5 never used includeIf, so it is safe for Windows. Upstream confirmation: actions/checkout#2425 v5 action.yml declares `using: node24`: https://raw.githubusercontent.com/actions/checkout/v5/action.yml 2. changeset-required.yml — floating actions/checkout@v4 + actions/setup-node@v4 3. docs-required.yml — same floating @v4 pattern Changes: - test.yml: both Windows checkout steps v4.2.2 → v5.0.1 (SHA 11bd71901bbe5b1630ceea73d27597364c9af683 → 93cb6efe18208431cddfb8368fd83d5badbf9bfd) - test.yml: update comment on Windows checkout to reflect v5 rationale - test.yml: no FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 was present on origin/next (already absent; the env block was on the main-branch version only) - changeset-required.yml: actions/checkout@v4 → @93cb6efe18208431cddfb8368fd83d5badbf9bfd (v5.0.1) - changeset-required.yml: actions/setup-node@v4 → @a0853c24544627f65ddf259abe73b1d18a591444 (v5.0.0) - docs-required.yml: same as changeset-required.yml SHAs resolved from upstream tags: - checkout v5.0.1: gh api repos/actions/checkout/git/ref/tags/v5.0.1 → 93cb6efe18208431cddfb8368fd83d5badbf9bfd - setup-node v5.0.0: gh api repos/actions/setup-node/git/ref/tags/v5.0.0 → a0853c24544627f65ddf259abe73b1d18a591444 Closes #445 Co-authored-by: CI Rebase Check <ci@gsd-redux>
1 parent d83e58e commit 381be43

3 files changed

Lines changed: 9 additions & 9 deletions

File tree

.github/workflows/changeset-required.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ jobs:
1616
changeset-lint:
1717
runs-on: ubuntu-latest
1818
steps:
19-
- uses: actions/checkout@v4
19+
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
2020
with:
2121
fetch-depth: 50
2222
- name: Fetch base ref for diff
2323
run: git fetch --depth=50 origin "${BASE_REF}:refs/remotes/origin/${BASE_REF}"
2424
env:
2525
BASE_REF: ${{ github.event.pull_request.base.ref }}
26-
- uses: actions/setup-node@v4
26+
- uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
2727
with:
2828
node-version: '24'
2929
- name: Run changeset lint

.github/workflows/docs-required.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ jobs:
1616
docs-lint:
1717
runs-on: ubuntu-latest
1818
steps:
19-
- uses: actions/checkout@v4
19+
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
2020
with:
2121
fetch-depth: 50
2222
- name: Fetch base ref for diff
2323
run: git fetch --depth=50 origin "${BASE_REF}:refs/remotes/origin/${BASE_REF}"
2424
env:
2525
BASE_REF: ${{ github.event.pull_request.base.ref }}
26-
- uses: actions/setup-node@v4
26+
- uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5.0.0
2727
with:
2828
node-version: '24'
2929
- name: Run docs-required lint

.github/workflows/test.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,10 @@ jobs:
132132
scope: windows
133133

134134
steps:
135-
# actions/checkout@v6 uses includeIf.gitdir: to inject auth on Windows.
136-
# On Windows git 2.54, the gitdir path comparison is unreliable, so use
137-
# v4 on Windows and v6 elsewhere.
138-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 (Windows)
135+
# Windows lane on checkout v5.0.1 (drops includeIf; no auth flake, uses Node 24 natively).
136+
# v6 uses includeIf.gitdir: for auth injection; on Windows git 2.54 the path comparison is
137+
# unreliable (https://github.com/actions/checkout/pull/2425). v5 never used includeIf.
138+
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1 (Windows)
139139
if: runner.os == 'Windows'
140140
with:
141141
fetch-depth: 0
@@ -231,7 +231,7 @@ jobs:
231231
shell: 'zsh {0}'
232232

233233
steps:
234-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 (Windows)
234+
- uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1 (Windows)
235235
if: runner.os == 'Windows'
236236
with:
237237
fetch-depth: 0

0 commit comments

Comments
 (0)